Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PKI Responses 3 #18596

Merged
merged 18 commits into from
Feb 17, 2023
Merged

Adding PKI Responses 3 #18596

merged 18 commits into from
Feb 17, 2023

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Jan 4, 2023 •
edited
Loading

path_fetch_*.go

Please see this RFC for implementation details.

File Path Response
path_fetch ca/pem, crl/*, cert/* Response
path_fetch_issuers issuers/* List operation, should have keys
path_fetch_issuers issuer/:issuer_ref/* Responses
path_fetch_keys keys/* List operation, should have keys
path_fetch_keys key/* Get, Update

Related PRs:

@vercel
Copy link

vercel bot commented Jan 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
vault 🔄 Building (Inspect) Jan 4, 2023 at 11:08PM (UTC)

@AnPucel AnPucel changed the title Anpucel/pki response3 Adding PKI Responses 3 Jan 4, 2023
@AnPucel AnPucel marked this pull request as ready for review January 9, 2023 21:11
@AnPucel AnPucel requested a review from a team January 9, 2023 21:11
@AnPucel AnPucel added this to the 1.13.0-rc1 milestone Jan 9, 2023
@AnPucel AnPucel requested a review from a team January 9, 2023 23:03
lursu
lursu approved these changes Jan 10, 2023
View reviewed changes
Copy link
Collaborator

@lursu lursu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just a couple of suggestions.

builtin/logical/pki/path_fetch_issuers.go Outdated Show resolved Hide resolved
builtin/logical/pki/path_fetch_keys.go Outdated Show resolved Hide resolved
AnPucel and others added 2 commits January 10, 2023 10:39
@AnPucel @lursu
Update list operation
0906574 
Co-authored-by: Leland Ursu <[email protected]>
@AnPucel @lursu
Update list operation
bc0fd01 
Co-authored-by: Leland Ursu <[email protected]>
sgmiller
sgmiller requested changes Jan 23, 2023
View reviewed changes
changelog/18596.txt Outdated Show resolved Hide resolved
@AnPucel AnPucel requested review from a team, fairclothjm and yhyakuna as code owners February 3, 2023 18:07
@AnPucel AnPucel requested a review from a team February 3, 2023 18:08
@AnPucel AnPucel modified the milestones: 1.13.0-rc1, 1.14 Feb 13, 2023
This was referenced Feb 15, 2023
Merged
Merged
Merged
@AnPucel AnPucel force-pushed the anpucel/PKIResponse3 branch from 3f21e9a to 5f223e0 Compare February 16, 2023 00:12
@sgmiller sgmiller self-requested a review February 16, 2023 15:56
averche
averche approved these changes Feb 16, 2023
View reviewed changes
builtin/logical/pki/path_fetch.go Outdated Show resolved Hide resolved
@AnPucel AnPucel merged commit 5cfb938 into main Feb 17, 2023
@AnPucel AnPucel deleted the anpucel/PKIResponse3 branch February 22, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@lursu lursu lursu approved these changes

@sgmiller sgmiller sgmiller approved these changes

@fairclothjm fairclothjm Awaiting requested review from fairclothjm

@yhyakuna yhyakuna Awaiting requested review from yhyakuna

Assignees
No one assigned
Labels
pr/no-changelog
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
4 participants
@AnPucel @sgmiller @lursu @averche