UI: OIDC callback bug. #18521
Merged
UI: OIDC callback bug. #18521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@austingebauer could you please have a look at this PR again. |
hashishaw
approved these changes
Jan 17, 2023
austingebauer
approved these changes
Jan 17, 2023
|
@davidspek Hi David, doing a little clean up work and noticed this PR was not yet merged. Looks like there are some conflicts. Would you mind fixing those and then we can go ahead and merge? |
Signed-off-by: David van der Spek <[email protected]>
Signed-off-by: David van der Spek <[email protected]>
Signed-off-by: David van der Spek <[email protected]>
davidspek
force-pushed
the
ui/oidc-event-filter
branch
from
eb9d0af to
808ed21
Compare
|
@Monkeychip I've just rebased the PR. |
raymonstah
pushed a commit
that referenced
this pull request
Mar 17, 2023
* don't error for other message events Signed-off-by: David van der Spek <[email protected]> * add changelog Signed-off-by: David van der Spek <[email protected]> * rename release note for changelog Signed-off-by: David van der Spek <[email protected]> --------- Signed-off-by: David van der Spek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #18138 as the branch needed to be renamed following this comment. CC'in @hashishaw and @austingebauer as you were reviewing the previous PR.
When implementing vault with our OIDC provider, the popup window never closes and the OIDC callback never succeeds. This is because the main window is listening for message events from the popup window. However, in our OIDC consent page other message events originating from Intercom are sent and these break the callback handling. This is because the code implemented in #13133 will error if the first message event is not the one Vault expects. This PR effectively inverses the
ifstatement so that thewhileloop will function properly and wait for the proper event to catch.The events listed in the browser by executing
monitorEvents(window,"message")in the browser console:The popup window for the OIDC login flow that is being referred to:
