Added OpenAPI response structures for sys endpoints #18515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AnPucel
reviewed
Dec 21, 2022
averche
reviewed
Dec 22, 2022
lursu
requested review from
danielehc and
dhuckins
and removed request for
danielehc
dhuckins
reviewed
Jan 6, 2023
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
…thub.com:hashicorp/vault into VAULT-12143/added_responses_for_sys_subsection_2
Co-authored-by: Daniel Huckins <[email protected]>
Co-authored-by: Daniel Huckins <[email protected]>
averche
reviewed
Feb 1, 2023
vault/logical_system_paths.go
Outdated
Comment on lines
1998
to
2001
| "keys_info": { | ||
| Type: framework.TypeMap, | ||
| Required: false, | ||
| }, |
There was a problem hiding this comment.
I did not see this parameter anywhere in the response, not sure if I'm missing something.
There was a problem hiding this comment.
sorry is actually "key_info" not keys... related line from handler.
Line 2840 in b741fa8
There was a problem hiding this comment.
The code you referenced seems to only apply to PolicyTypeEGP whereas the function deals with PolicyTypeACL.
vault/logical_system_paths.go
Outdated
Comment on lines
2020
to
2023
| "keys_info": { | ||
| Type: framework.TypeMap, | ||
| Required: false, | ||
| }, |
Co-authored-by: Anton Averchenkov <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
Co-authored-by: Anton Averchenkov <[email protected]>
…thub.com:hashicorp/vault into VAULT-12143/added_responses_for_sys_subsection_2
averche
reviewed
Feb 2, 2023
Co-authored-by: Anton Averchenkov <[email protected]>
averche
reviewed
Feb 2, 2023
There was a problem hiding this comment.
Please update other tests for the affected functionality (e.g. https://github.com/hashicorp/vault/blob/main/vault/external_tests/mfa/login_mfa_test.go for sys/mfa)
dhuckins
approved these changes
Feb 3, 2023
averche
approved these changes
Feb 15, 2023
lursu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding response objects for the sys endpoints laid out in VAULT-12143.