Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAULT-12112: add openapi response structures for /sys/capabilities* endpoints #18468

Merged
merged 5 commits into from
Feb 16, 2023
Merged

VAULT-12112: add openapi response structures for /sys/capabilities* endpoints #18468

merged 5 commits into from
Feb 16, 2023

Conversation

dhuckins
Copy link
Contributor

@dhuckins dhuckins commented Dec 19, 2022 •
edited
Loading

Path Operation response docs
/sys/capabilities-accessor UPDATE link
/sys/capabilities UPDATE link
/sys/capabilities-self UPDATE link

@dhuckins
add capabilities
e2c8d53 
Signed-off-by: Daniel Huckins <[email protected]>
@dhuckins
added change log
3680bea 
Signed-off-by: Daniel Huckins <[email protected]>
@dhuckins dhuckins added this to the 1.13.0-rc1 milestone Dec 22, 2022
@dhuckins dhuckins marked this pull request as ready for review December 22, 2022 19:43
@dhuckins dhuckins changed the base branch from dh/response-structures-sys-1 to main December 22, 2022 19:48
averche
averche approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for all the links!

@dhuckins dhuckins changed the title add capabilities response structures add openapi response structures for /sys/capabilities* endpoints Dec 23, 2022
@dhuckins dhuckins changed the title add openapi response structures for /sys/capabilities* endpoints VAULT-12112: add openapi response structures for /sys/capabilities* endpoints Jan 5, 2023
@dhuckins
add test
5fa0192 
Signed-off-by: Daniel Huckins <[email protected]>
@dhuckins
use nil for dynamic fields
8e6c2a6 
Signed-off-by: Daniel Huckins <[email protected]>
@averche averche modified the milestones: 1.13.0-rc1, 1.14 Feb 13, 2023
@dhuckins dhuckins merged commit 6dafb4f into main Feb 16, 2023
@dhuckins dhuckins deleted the dh/response-structures-sys-1-capabilities branch February 16, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche approved these changes

@lursu lursu Awaiting requested review from lursu

@AnPucel AnPucel Awaiting requested review from AnPucel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@dhuckins @averche