Correctly distinguish empty issuer names in PKI #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using client.Logical().JSONMergePatch(...) with an empty issuer name, patch incorrectly reports: > issuer name contained invalid characters In this case, both the error in getIssuerName(...) is incorrect and patch should allow setting an empty issuer name explicitly. Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
|
I completely agree with the new patch behaviour. Could you expand a bit though on why we want to keep the POST behaviour different, feels a bit odd that if an end-user wants to blank out an issuer name that it must be done through a PATCH command only? Is this just a way to force people to use PATCH semantics for updates? |
|
@stevendpclark On POST/ Up to you :) |
stevendpclark
approved these changes
Jan 10, 2023
|
Thank you! |
This was referenced Jan 10, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Correctly distinguish empty issuer names When using client.Logical().JSONMergePatch(...) with an empty issuer name, patch incorrectly reports: > issuer name contained invalid characters In this case, both the error in getIssuerName(...) is incorrect and patch should allow setting an empty issuer name explicitly. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog Signed-off-by: Alexander Scheel <[email protected]> * Add tests Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Correctly distinguish empty issuer names When using client.Logical().JSONMergePatch(...) with an empty issuer name, patch incorrectly reports: > issuer name contained invalid characters In this case, both the error in getIssuerName(...) is incorrect and patch should allow setting an empty issuer name explicitly. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog Signed-off-by: Alexander Scheel <[email protected]> * Add tests Signed-off-by: Alexander Scheel <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
deleted the
cipherboy-fix-name-on-empty-but-provided-issuer-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
client.Logical().JSONMergePatch(...)with an empty issuer name, patch incorrectly reports:In this case, both the error in getIssuerName(...) is incorrect and patch should allow setting an empty issuer name explicitly.
Signed-off-by: Alexander Scheel <[email protected]>Notably, while this also affects
vault write, the new error message should be clearer and users can simply elide theissuer_nameparameter (with empty value) and the the same behavior (clearing the name). However, forvault patchthere is no equivalent and thus they have to have this bug fix.