Vault 11795 vault cli verify s ign #18437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 'Alex Scheel' <[email protected]>
cipherboy
reviewed
Dec 19, 2022
|
Looking like a good start! |
cipherboy
approved these changes
Jan 25, 2023
| return 0 | ||
| } | ||
|
|
||
| func verifySignBetween(client *api.Client, issuerPath string, issuedPath string) (error, map[string]bool) { |
There was a problem hiding this comment.
A nit for a future PR: Go return arg order is typically reversed, with the error/ok boolean being the last item.
stevendpclark
approved these changes
Jan 26, 2023
| return fmt.Errorf("error: unable to fetch issuer %v: %w", issuerPath, err), nil | ||
| } | ||
| if len(issuedPath) <= 2 { | ||
| return fmt.Errorf(fmt.Sprintf("%v", issuedPath)), nil |
There was a problem hiding this comment.
nit: no need for fmt.Sprintf within a fmt.Errorf
|
|
||
| pathMatch := false | ||
| for _, cert := range caChain { | ||
| if strings.TrimSpace(cert) == strings.TrimSpace(issuerCertPem) { // TODO: Decode into ASN1 to Check |
There was a problem hiding this comment.
nit: Was this a future TODO or does this need to be addressed sooner? Similar for the TODO below on line 177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New PKI CLI command that allows someone to check the relationship between a potential issuer, and a certificate it potentially issued.
[x] Tests Added - more ideas welcome
[x] Help (man?) pages exist
Functionality Test:
Docs to come in a separate PR.