Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Update database to connection name on role #18350

Merged
merged 2 commits into from
Dec 14, 2022
Merged

UI: Update database to connection name on role #18350

merged 2 commits into from
Dec 14, 2022

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Dec 13, 2022 •
edited
Loading

Changes the language on database role from Database to Connection name

AFTER
Screen Shot 2022-12-13 at 4 27 21 PM

BEFORE
Screen Shot 2022-12-13 at 4 27 31 PM

@hashishaw hashishaw added the ui label Dec 13, 2022
@hashishaw hashishaw added this to the 1.13.0-rc1 milestone Dec 13, 2022
@hashishaw hashishaw linked an issue Dec 13, 2022 that may be closed by this pull request
In UI Database Roles page, it should say 'Connection' instead of 'Database' #18261
Closed
@hashishaw hashishaw marked this pull request as ready for review December 13, 2022 22:28
kiannaquach
kiannaquach approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@kiannaquach kiannaquach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@hashishaw hashishaw merged commit 58e9f4f into main Dec 14, 2022
Closed
@hashishaw hashishaw deleted the ui/GH-18261/update-database-language branch December 14, 2022 16:24
This was referenced Dec 14, 2022
Closed
Closed
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
UI: Update database to connection name on role (#18350)
ff99000 
* Update database to connection name on role

* Add changelog
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
UI: Update database to connection name on role (#18350)
f5fc293 
* Update database to connection name on role

* Add changelog
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
UI: Update database to connection name on role (#18350)
60c6708 
* Update database to connection name on role

* Add changelog
This was referenced Dec 14, 2022
Merged
Merged
Merged
@hellobontempo hellobontempo modified the milestones: 1.13.0-rc1, 1.10.10 Dec 14, 2022
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
Backport UI: Update database to connection name on role (#18350) (#18367
a98d33f 
)

* Update database to connection name on role

* Add changelog
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
Backport UI: Update database to connection name on role (#18350) (#18368
d975ed4 
)

* Update database to connection name on role

* Add changelog
hashishaw added a commit that referenced this pull request Dec 14, 2022
@hashishaw
Backport UI: Update database to connection name on role (#18350) (#18369
5225388 
)

* Update database to connection name on role

* Add changelog
AnPucel pushed a commit that referenced this pull request Jan 14, 2023
@hashishaw @AnPucel
UI: Update database to connection name on role (#18350)
6df3674 
* Update database to connection name on role

* Add changelog
AnPucel pushed a commit that referenced this pull request Feb 3, 2023
@hashishaw @AnPucel
UI: Update database to connection name on role (#18350)
936cff1 
* Update database to connection name on role

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiannaquach kiannaquach kiannaquach approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
1.10.10
Development

Successfully merging this pull request may close these issues.

In UI Database Roles page, it should say 'Connection' instead of 'Database'
3 participants
@hashishaw @kiannaquach @hellobontempo