VAULT-11830: Expand NodeStatusReporter with new fields #18302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
changed the title
hghaf099
approved these changes
Jan 4, 2023
vault/core.go
Outdated
| } | ||
|
|
||
| listeners := conf.(*server.Config).Listeners | ||
| if lns == nil { |
There was a problem hiding this comment.
I am seeing a millions of GH warnings about an undefined lns :)
There was a problem hiding this comment.
@ccapurso I think this still needs to be addressed
There was a problem hiding this comment.
Oh shoot! I fixed that but apparently I didn't commit and push. Thanks!
There was a problem hiding this comment.
Actually, it looks like I did and the build works locally. I'll dig in and try to figure that out.
hghaf099
reviewed
Jan 6, 2023
|
Looks good! Just a couple of last minor comments. |
biazmoreira
approved these changes
Jan 6, 2023
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* expand NodeStatusReporter with new fields * only call IsRaftVoter if using raft storage * add changelog entry * fix listeners * return LogLevel as enum * update github.com/hashicorp/vault/vault/hcp_link/proto * add changelog entry * bump github.com/hashicorp/vault/vault/hcp_link/proto * go mod tidy
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* expand NodeStatusReporter with new fields * only call IsRaftVoter if using raft storage * add changelog entry * fix listeners * return LogLevel as enum * update github.com/hashicorp/vault/vault/hcp_link/proto * add changelog entry * bump github.com/hashicorp/vault/vault/hcp_link/proto * go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The associated PR #18203 introduces the following fields to
LinkedClusterNodeStatusResponse:HostnameListenerAddressesOperatingSystemOperatingSystemVersionLogLevelActiveTimeRaftStatuswith underlyingIsVoterfieldThis PR modifies the
GetNodeStatushandler ofNodeStatusReporterto includes these fields in the response.Hostname,OperatingSystem, andOperatingSystemVersionare all obtained viahost.InfoWithContextwhich is also used by thesys/host-infoendpoint.A few new
Coremethods have been added for the purpose of de-coupling viaWrappedCoreNodeStatus:ListenerAddressessurfaces the configured listener addressesLogLevelsurfaces the underlyingCore.logLevelto expose the configured log level.IsRaftVoterusesCore.raftInfoto determine if the node is a raft voterTODO:
go get github.com/hashicorp/vault/vault/hcp_link/protoonce VAULT-11827: Add new Link node level fields #18203 since the current version ingo.modis pointing to@vault-11827-node-level-fields