Backport of VAULT-8336 Fix default rate limit paths into release/1.10.x #18282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/violethynes/VAULT-8336/rationally-stirred-mallard
branch
2 times, most recently
from
82a391e to
2922b53
Compare
VioletHynes
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #18273 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
The below text is copied from the body of the original PR.
It seems like this never really worked, unfortunately. We check the request path against the default exempt list to see if the request path is a prefix of any, but since the request path was
sys/health, it wasn't a prefix of/v1/sys/health. After this change, everything seems to work as expected (assys/healthis indeed a prefix ofsys/health).The test I added will fail if this is broken again in the future, and all tests pass after this change (both OSS and Ent).
I updated the docs to make it clearer for users wanting to customize their set of defaults.
Overview of commits