plugins: Mount missing plugin entries and skip loading #18189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
changed the title
mpalmi
changed the title
mpalmi
changed the title
tomhjp
reviewed
Dec 1, 2022
Co-authored-by: Tom Proctor <[email protected]>
tomhjp
approved these changes
Dec 2, 2022
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Skip plugin startup for missing plugins * Skip secrets startup for missing plugins * Add changelog for bugfix * Make plugin handling on unseal version-aware * Update plugin lazy-load logic/comments for readability * Add register/mount/deregister/seal/unseal go test * Consolidate lazy mount logic to prevent inconsistencies Co-authored-by: Tom Proctor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an inconsistency and logic issue in the previous unseal logic. We now consistently check the plugincatalog for secrets engines and auth methods and appropriately skip the backend startup for deregistered plugins.
This probably needs an unseal test to prevent regression.
This PR should resolve VAULT-11858