plugins: Handle mount/enable for shadowed builtins #17879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
4 times, most recently
from
6b18d0a to
fc7419d
Compare
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
2 times, most recently
from
5d67bae to
a92ff97
Compare
ncabatoff
reviewed
Nov 21, 2022
tomhjp
reviewed
Nov 21, 2022
mpalmi
changed the title
mpalmi
changed the title
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
2 times, most recently
from
a43dc69 to
3dea37d
Compare
fairclothjm
reviewed
Nov 29, 2022
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
from
76c0fa2 to
c1346b1
Compare
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
from
7c4064a to
cb4460a
Compare
tomhjp
reviewed
Dec 1, 2022
raskchanky
reviewed
Dec 1, 2022
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
2 times, most recently
from
73da5df to
d5a5e45
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mpalmi
commented
Dec 6, 2022
mpalmi
force-pushed
the
handle-shadowed-builtins
branch
from
575ce08 to
cd76ff2
Compare
mpalmi
removed request for
a team,
tjperry07,
samsalisbury and
marianoasselborn
divyaac
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Allow mounting external plugins with same name/type as deprecated builtins * Add some go tests for deprecation status handling * Move timestamp storage to post-unseal * Add upgrade-aware deprecation shutdown and tests
AnPucel
pushed a commit
that referenced
this pull request
Jan 14, 2023
* Allow mounting external plugins with same name/type as deprecated builtins * Add some go tests for deprecation status handling * Move timestamp storage to post-unseal * Add upgrade-aware deprecation shutdown and tests
AnPucel
pushed a commit
that referenced
this pull request
Feb 3, 2023
* Allow mounting external plugins with same name/type as deprecated builtins * Add some go tests for deprecation status handling * Move timestamp storage to post-unseal * Add upgrade-aware deprecation shutdown and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some handling for shadowed builtins (external plugins with the same name/type as a builtin plugin). Also includes some test improvements and a more official coreConfig for the
PendingRemovalenvironment variable.In an effort to address concerns around post-upgrade unseals, this PR also introduces a more forgiving deprecation handling framework. In the event that Vault is unsealing for the first time (or has never successfully unsealed in the past), we shutdown to prevent drift from the pre-upgrade state. If Vault has already been unsealed with the deprecated entry, we continue to mount the data, but skip the backend initialization. This allows the data to be preserved and gives the operator a chance to remediate any issues on the newer version of Vault.
This resolves VAULT-9372 and VAULT-11863.