ui: mfa: use proper request id generation #17835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
NB for backports: apply changes to ui/mirage/handlers/mfa.js (according to commit ca14c19). |
rockdrilla
changed the title
hashishaw
suggested changes
Nov 9, 2022
There was a problem hiding this comment.
Thank you for catching this! We'd like to instead use the built-in randomUUID method so we don't have extra dependencies. Once that's updated we can ship it 🚀
Fixes: 712cc9e, ca14c19 Signed-off-by: Konstantin Demin <[email protected]>
|
@rockdrilla would you please push an empty commit so that the CircleCI jobs kick off? 🙏 |
|
@hashishaw I think CircleCI is stuck due to Vercel (it asks "Authorize Fork Deployment"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
crypto.randomUUID()to generatemfa_request_idinstead of magic withMath.random().Fixes: 712cc9e, ca14c19
Signed-off-by: Konstantin Demin [email protected]