Fix gen_openapi.sh script to load plugins #17752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhuckins
approved these changes
Nov 1, 2022
I'm not a big fan of this script. Moving some or all of it into Go would be ideal. I think we are starting vault so that we can hit the |
|
so the actual spec is generated on the fly? |
|
Yes, it is generated on the fly. I believe a lot of the path/endpoint logic is in this funciton. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
gen_openapi.shhas been broken since #16846, which changed the format ofregistry.go. This PR fixes the regular expressions used to parse the file.Note: this is a temporary solution to fix the immediate failure and the script is still very brittle. In the future, a better solution should be considered (e.g. introduce a new endpoint to return the contents of
registry.go)Fixes: VAULT-9672