PKI: Add support for signature_bits param to the intermediate/generate api #17388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e api - Mainly to work properly with GCP backed managed keys, we need to issue signatures that would match the GCP key algorithm. - At this time due to golang/go#45990 we can't issue PSS signed CSRs, as the libraries in Go always request a PKCS1v15. - Add an extra check in intermediate/generate that validates the CSR's signature before providing it back to the client in case we generated a bad signature such as if an end-user used a GCP backed managed key with a RSA PSS algorithm. - GCP ignores the requested signature type and always signs with the key's algorithm which can lead to a CSR that says it is signed with a PKCS1v15 algorithm but is actually a RSA PSS signature
cipherboy
reviewed
Oct 3, 2022
| requireED25519SignedBy(t, cert, typedKey) | ||
| default: | ||
| require.Fail(t, "unknown public key type %#v", key) | ||
| func requireSignedBy(t *testing.T, cert *x509.Certificate, signingCert *x509.Certificate) { |
There was a problem hiding this comment.
👍 -- I had thought of this change a while ago, but never actually submitted it, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to work properly with GCP backed managed keys, we need to issue signatures that would match the GCP key algorithm.
At this time due to crypto/x509: can't verify signature on RSA-PSS certificate requests it created golang/go#45990 we can't issue PSS signed CSRs, as the libraries in Go always request a PKCS1v15.
Add an extra check in intermediate/generate that validates the CSR's signature before providing it back to the client in case we generated a bad signature such as if an end-user used a GCP backed managed key with a RSA PSS algorithm.