Store login MFA secret with tokenhelper #17040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
commented
Oct 13, 2022
|
I don't think your |
Oops! Thanks, fixed. |
|
Is it possible to write a test for this behaviour? It would make me feel a bit comfier that we won't have regressions in this area without it being caught! |
Sure thing. I was actually considering it, so thanks for the nudge! |
hghaf099
reviewed
Oct 17, 2022
hghaf099
reviewed
Oct 18, 2022
mpalmi
force-pushed
the
fix-mfa-tokenhelper
branch
2 times, most recently
from
cb5ea70 to
1940983
Compare
mpalmi
commented
Oct 26, 2022
mpalmi
commented
Oct 26, 2022
mpalmi
commented
Oct 26, 2022
raskchanky
approved these changes
Oct 26, 2022
hghaf099
approved these changes
Oct 26, 2022
mpalmi
force-pushed
the
fix-mfa-tokenhelper
branch
from
765e3fc to
a900108
Compare
This was referenced Oct 26, 2022
mpalmi
added a commit
that referenced
this pull request
Oct 26, 2022
* Store login MFA secret with tokenhelper * Clean up and refactor tokenhelper paths * Refactor totp test code for re-use * Add login MFA command tests * Use longer sleep times and sha512 for totp test * Add changelog
mpalmi
added a commit
that referenced
this pull request
Oct 26, 2022
* Store login MFA secret with tokenhelper * Clean up and refactor tokenhelper paths * Refactor totp test code for re-use * Add login MFA command tests * Use longer sleep times and sha512 for totp test * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
loginpath to store a token when using single-phase MFA validation. Still need to do some testing to see if this breaks any of the pre-existing functionality (particularly two-phase MFA).Fixes: #16928