UI: JWT Auth Browser Popup warning. Resolves: #10753 #17009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zofskeez
requested changes
Sep 8, 2022
zofskeez
approved these changes
Sep 12, 2022
hashishaw
approved these changes
Sep 15, 2022
|
hey @chelshaw do you know if this will make it out with the next 1.12 release - I believe it's not made it out with the 1.12.0 GA? |
|
@aphorise - It looks like this got lost in the shuffle, sorry about that! The CircleCI tests aren't running which is prohibiting this PR from merging. I'm wondering if it could be due to following the fork instead of the upstream repo CircleCi troubleshooting
@hsimon-hashicorp - any thoughts? |
|
Closing in favour of #18787 |
auto-merge was automatically disabled
January 23, 2023 14:53
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify warning and message as per community suggestion (#10753) to be more explicit about blocked pop-ups.