Prepare multiplexing support for database plugins #16995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxcoulombe
requested review from
a team,
austingebauer,
robmonte,
vinay-gopalan and
Zlaticanin
|
Are we sure that this PR wouldn't warrant a changelog? I think we might have to add one as an |
+ converted mysql
…ltiplexingMigration
vinay-gopalan
approved these changes
Sep 6, 2022
austingebauer
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing multiplexing support for all built-in database plugins. Multiplexing is only supported for external plugins so this change is effectively a noop but prepares the field for future projects. As it is a noop for the time being I decided against including a changelog but let me know it you think it'd make sense to include one.
All plugins were tested locally to confirm they still work as expected but share a single process between all plugin instances.