Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add _remaining tidy metrics. #16702

Merged
merged 3 commits into from
Aug 23, 2022
Merged

Add _remaining tidy metrics. #16702

merged 3 commits into from
Aug 23, 2022

Conversation

kitography
Copy link
Contributor

This adds two metrics during the tidy operation representing how many certificates were iterated over, but not deleted.

cipherboy
cipherboy approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure why this is still in draft, but I like it? :-)

@kitography
Copy link
Contributor Author

This was a draft because it didn't have tests, nor documentation. It does now :)

@kitography kitography marked this pull request as ready for review August 23, 2022 15:03
@kitography kitography requested a review from taoism4504 as a code owner August 23, 2022 15:03
@kitography kitography merged commit 51d8cdc into main Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy approved these changes

@taoism4504 taoism4504 Awaiting requested review from taoism4504

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kitography @cipherboy