Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of identity/oidc: reorder authorization endpoint validation for invalid redirect uris into release/1.11.x #16630

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16601 to be assessed for backporting due to the inclusion of the label backport/1.11.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/vault/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


This PR reorders validation in the Authorization Endpoint in order to detect invalid redirect_uri values sooner. This is important because an invalid redirect_uri must not result in the user agent redirecting to the relying party per 3.1.2.6. Authentication Error Response.


Overview of commits

@hashicorp-cla
Copy link

hashicorp-cla commented Aug 8, 2022

CLA assistant check
All committers have signed the CLA.

@austingebauer austingebauer force-pushed the backport/oidc-redirect-uri-validation/mainly-unique-magpie branch from 4cd16ca to dc4dc81 Compare August 8, 2022 17:33
@austingebauer austingebauer marked this pull request as ready for review August 8, 2022 17:33
@austingebauer austingebauer merged commit 4471c3b into release/1.11.x Aug 8, 2022
@austingebauer austingebauer deleted the backport/oidc-redirect-uri-validation/mainly-unique-magpie branch August 8, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants