Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup, wrap, rewrap and unwrap token rename with description #16489

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

linda9379
Copy link
Contributor

Renamed label of wrapping token to wrapped token under Tools for Lookup, Unwrap and Rewrap. Added descriptions for them as well. Changed label under Wrap as well. Note that if an error is thrown, it still says wrapping token since that error message comes from the backend
Screen Shot 2022-07-28 at 12 46 10 PM
Screen Shot 2022-07-28 at 12 46 23 PM
Screen Shot 2022-07-28 at 12 46 32 PM
Screen Shot 2022-07-28 at 12 47 29 PM

@linda9379 linda9379 added the ui label Jul 28, 2022
@linda9379 linda9379 changed the title Lookup, rewrap and unwrap token rename with description Lookup, wrap, rewrap and unwrap token rename with description Jul 28, 2022
Copy link
Contributor

@hashishaw hashishaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks great, thank you!

@hashishaw hashishaw added this to the 1.12.0-rc1 milestone Jul 28, 2022
@linda9379 linda9379 merged commit cf64316 into main Jul 28, 2022
@linda9379 linda9379 deleted the ui/VAULT-7230/lookup_token_rename branch July 28, 2022 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants