Increase the allowed concurrent gRPC streams #16327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncabatoff
reviewed
Jul 18, 2022
vault/cluster/cluster.go
Outdated
|
|
||
| // By default this is 250 which can be too small on high traffic | ||
| // clusters with many forwarded or replication gRPC connections. | ||
| MaxConcurrentStreams: math.MaxUint32, |
There was a problem hiding this comment.
Do we want an opt-out feature toggle? Just worried about unforeseen consequences.
raskchanky
approved these changes
Jul 19, 2022
ncabatoff
approved these changes
Jul 20, 2022
added 2 commits
July 20, 2022 11:36
raskchanky
approved these changes
Jul 20, 2022
ncabatoff
approved these changes
Jul 20, 2022
This was referenced Jul 20, 2022
briankassouf
added a commit
that referenced
this pull request
Jul 20, 2022
* Increase the allowed concurrent gRPC streams * Add a env override for the max streams setting * Add changelog * go fmt * fix builds on 32bit systems
briankassouf
added a commit
that referenced
this pull request
Jul 20, 2022
* Increase the allowed concurrent gRPC streams * Add a env override for the max streams setting * Add changelog * go fmt * fix builds on 32bit systems Co-authored-by: Brian Kassouf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
http2.Serverallows for 250 concurrent streams per host. This limit can cause bottlenecks on clusters with many forwarded requests/rpcs. This changes the default to match what the gRPC library uses:MaxUint32.