Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI Remove recent instances of sessionStorage #16170

Merged
merged 2 commits into from
Jun 28, 2022
Merged

UI Remove recent instances of sessionStorage #16170

merged 2 commits into from
Jun 28, 2022

Conversation

hashishaw
Copy link
Contributor

This PR removes remaining references to sessionStorage. Here's what happened:

  1. We swapped localStorage in favor of sessionStorage in UI: Switch usage of localStorage to sessionStorage #14054
  2. OIDC bugfix in OIDC Logout Bug #14545 used sessionStorage because that's what was standard at the time
  3. Team realized the move to sessionStorage was a mistake, and reverted 14054 in Revert UI: replace localStorage with sessionStorage #15769
  4. Changes from 14545 are still present in 1.11 onward, and this PR is to fix that.

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.11.x labels Jun 28, 2022
@hashishaw hashishaw added this to the 1.11.1 milestone Jun 28, 2022
zofskeez
zofskeez approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@zofskeez zofskeez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@hashishaw hashishaw enabled auto-merge (squash) June 28, 2022 16:55
@hashishaw hashishaw merged commit 3421496 into main Jun 28, 2022
Merged
@hashishaw hashishaw deleted the ui/remove-session-storage branch May 6, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zofskeez zofskeez zofskeez approved these changes

Assignees
No one assigned
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Milestone
1.11.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hashishaw @zofskeez