fix bug with allowed_users_template and add allowed_domains_template for SSH role #16056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This should also fix #14901. |
|
@taoism4504 is any additional work required for this? Thanks 😃 |
|
Thanks @f4z3r! I'll see if I can get an engineer to review this soon. :) |
schultz-is
approved these changes
Aug 16, 2022
|
Howdy @f4z3r, thanks for the contribution! This looks great! Edit: Looks like there are a couple merge conflicts. If you can fix those up we can bring this in. Again, thanks for tackling this! |
…s_template field in SSH role configuration, closes hashicorp#10943
|
Hi @schultz-is Thanks for the review. I rebased on the current state of |
|
Thanks for the contribution @f4z3r! |
This was referenced Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the
allowed_domains_templatefield when configuring SSH roles on the SSH secret engine (as explained in issue #10943). It also fixes an issue thatallowed_users_templateactually affected the domain templating. I also directly added the documentation for it.