Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse ha_storage in config #15900

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Parse ha_storage in config #15900

merged 3 commits into from
Jun 9, 2022

Conversation

akshya96
Copy link
Contributor

@akshya96 akshya96 commented Jun 8, 2022

#14043
The gh issue is specific to zookeeper but this is applicable for all ha_storage backends
When providing boolean options to an ha_storage backend (ex. tls_enabled, tls_skip_verify) vault cannot parse them. It only accepts string values for boolean fields i.e; "true" and "false"

The parsing works well for storage backends. Therefore, changed the parsing similar to parsing values for storage backend

@akshya96 akshya96 requested review from a team June 8, 2022 23:30
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A small test to verify the changes address #14043 would be prudent. There are likely already tests for config parsing at this level so we might just need to modify one slightly.

@akshya96 akshya96 requested a review from ccapurso June 9, 2022 18:48
@akshya96 akshya96 merged commit f831b96 into main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants