Dynamic parameter for mountpaths #15835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnPucel
changed the title
AnPucel
changed the title
AnPucel
changed the title
averche
reviewed
Jun 14, 2022
AnPucel
commented
Jun 14, 2022
averche
reviewed
Jun 15, 2022
raskchanky
reviewed
Jun 16, 2022
raskchanky
reviewed
Jun 22, 2022
averche
reviewed
Jun 23, 2022
averche
reviewed
Jun 23, 2022
averche
reviewed
Jun 23, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This query parameter will be primarily for DevEx and code generation usage. The idea is to replace hard coded mount paths in the OpenApi spec with a dynamic parameter i.e.
{mountPath}.When the new call is made to
/sys/internal/specs/openapi?generic_paths=truethe resulting OpenApi spec will have"paths": { "/auth/{mountPath}/login/": { "description": "", "parameters": [ { "name": "mountPath", "description": "Path that the backend was mounted at", "in": "path", "schema": { "type": "string" }, "required": true } ],The resulting generated code will allow users of the client library to pass through a mount path that would've otherwise been hardcoded as e.g.
approle