Backport of Update AWS auth method certificates into release/1.11.x #15732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-6394/aws-auth-sha1/constantly-hip-beagle
branch
from
131c05a to
4e1bbec
Compare
hc-github-team-secure-vault-core
force-pushed
the
backport/vault-6394/aws-auth-sha1/constantly-hip-beagle
branch
from
2348378 to
230f7d6
Compare
tvoran
approved these changes
Jun 1, 2022
|
Thanks! |
…constantly-hip-beagle
swenson
deleted the
backport/vault-6394/aws-auth-sha1/constantly-hip-beagle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15719 to be assessed for backporting due to the inclusion of the label backport/1.11.x.
The below text is copied from the body of the original PR.
Add tests that the
rsa2048document can also be verified using thepkcs7field for AWS auth.Due to the use of SHA-1-based signatures for the
identityandpkcs7methods, we want to encourage moving toward using the RSA 2048 workflow,
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/verify-rsa2048.html
This doesn't require code changes for Vault necessarily, but adding in
the (many) certificates will help end users.
Also adds
rsa2048option to API to fetch the RSA 2048 signature.I will make a PR to update to the AWS auth docs to document the RSA 2048
flow soon after this.
I ran the AWS acceptance tests manually to verify that the RSA 2048 flow works as expected.
Overview of commits