Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usage documentation for new Kubernetes Secrets Engine #15527

Merged
merged 18 commits into from
May 20, 2022

Conversation

swenson
Copy link
Contributor

@swenson swenson commented May 19, 2022

No description provided.

@swenson swenson requested review from tvoran and tomhjp May 19, 2022 23:25
@swenson swenson requested a review from taoism4504 as a code owner May 19, 2022 23:25
Copy link
Contributor

@tomhjp tomhjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great 👍

website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Show resolved Hide resolved
@swenson
Copy link
Contributor Author

swenson commented May 20, 2022

Updated with all of the suggestions (except [0]) taken into account, I believe.

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a couple small nits.

website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
website/content/docs/secrets/kubernetes.mdx Outdated Show resolved Hide resolved
Christopher Swenson and others added 2 commits May 20, 2022 12:55
@swenson
Copy link
Contributor Author

swenson commented May 20, 2022

Thanks!

@swenson swenson merged commit a016791 into main May 20, 2022
@swenson swenson deleted the vault-6180-docs-kubernetes-secrets-engine-usage branch May 20, 2022 20:37
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
…15527)

Add usage documentation for new Kubernetes Secrets Engine

Co-authored-by: Tom Proctor <[email protected]>
Co-authored-by: Theron Voran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants