Return the signed ca in the ca_chain response field within sign-intermediate api call. #15524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stevendpclark
commented
May 19, 2022
stevendpclark
commented
- When signing a CA certificate we should include it along with the issuers CA chain in the response.
- When signing a CA certificate we should include it along with the signing CA's CA chain in the response.
cipherboy
reviewed
May 20, 2022
| if cb.CAChain != nil && len(cb.CAChain) > 0 { | ||
| resp.Data["ca_chain"] = cb.CAChain | ||
| } | ||
| resp.Data["ca_chain"] = caChain | ||
|
|
||
| case "pem_bundle": | ||
| resp.Data["certificate"] = cb.ToPEMBundle() |
There was a problem hiding this comment.
This is what makes me think this is a good idea: this gives you leaf + chain of the cert in the certificate field. :-) Avoids the need for concat.
cipherboy
reviewed
May 20, 2022
cipherboy
approved these changes
May 20, 2022
stevendpclark
force-pushed
the
stevendpclark/return-signed-cert-in-chain-sign-intermediate
branch
from
6c472b7 to
f43046e
Compare
stevendpclark
deleted the
stevendpclark/return-signed-cert-in-chain-sign-intermediate
branch
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
…mediate api call. (hashicorp#15524) * Return signed ca as part of ca_chain field within sign-intermediate - When signing a CA certificate we should include it along with the signing CA's CA chain in the response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.