Forward autopilot state reqs, avoid self-dialing #15493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de state. Forward autopilot state requests to the active node. Avoid self-dialing due to stale advertisement.
ccapurso
approved these changes
May 18, 2022
Comment on lines
+188
to
+192
| // At the top of this function we return early when we're the active node. | ||
| // If we're not the active node, and there's a stale advertisement pointing | ||
| // to ourself, there's no point in paying any attention to it. And by | ||
| // disregarding it, we can avoid a panic in raft tests using the Inmem network | ||
| // layer when we try to connect back to ourself. |
There was a problem hiding this comment.
Love this comment, thanks!
…rcising redirection.
ncabatoff
commented
May 18, 2022
| // to ourself, there's no point in paying any attention to it. And by | ||
| // disregarding it, we can avoid a panic in raft tests using the Inmem network | ||
| // layer when we try to connect back to ourself. | ||
| if adv.ClusterAddr == c.ClusterAddr() && adv.RedirectAddr == c.redirectAddr { |
There was a problem hiding this comment.
I had to also take RedirectAddr into consideration, otherwise tests that exercise redirection (and thus don't have a valid cluster addr) would break.
raskchanky
approved these changes
May 18, 2022
ccapurso
approved these changes
May 18, 2022
briankassouf
approved these changes
May 18, 2022
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
Make sure that autopilot is disabled when we step down from active node state. Forward autopilot state requests to the active node. Avoid self-dialing due to stale advertisement.
ncabatoff
added a commit
that referenced
this pull request
Mar 23, 2023
ncabatoff
added a commit
that referenced
this pull request
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that autopilot is disabled when we step down from active node state. Forward autopilot state requests to the active node. Avoid self-dialing due to stale advertisement from when we used to be active node.