Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Globally scoped MFA method Get/List endpoints #15248

Merged
merged 5 commits into from
May 17, 2022

Conversation

hghaf099
Copy link
Contributor

@hghaf099 hghaf099 commented Apr 30, 2022

Addresses VAULT-5993 which is requesting to add a couple of globally scoped endpoints:

  1. To read MFA config agnostic of MFA type /identity/mfa/method/:id
  2. To list all MFA methods agnostic of MFA type /identity/mfa/method?list=true

A bug is fixed as well where reading operation will return a method of a different type if a valid id is provided.

@hghaf099 hghaf099 marked this pull request as ready for review May 2, 2022 19:03
@hghaf099 hghaf099 requested a review from a team May 2, 2022 19:03
@hghaf099 hghaf099 added this to the 1.11.0-rc1 milestone May 11, 2022
@hghaf099 hghaf099 requested a review from ccapurso May 16, 2022 14:14
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided one small comment about potentially exposing unwanted information in an error string but otherwise looks good!

vault/login_mfa.go Outdated Show resolved Hide resolved
@hghaf099 hghaf099 merged commit 4eed18a into main May 17, 2022
@hghaf099 hghaf099 deleted the vault-5993-globally-scoped-mfa-method-get-endpoints branch May 17, 2022 18:54
hghaf099 added a commit that referenced this pull request May 17, 2022
* Globally scoped MFA method Get/List endpoints

* Adding CL

* minor changes

* removing unwanted information from an error msg
hghaf099 added a commit that referenced this pull request May 17, 2022
* Globally scoped MFA method Get/List endpoints

* Adding CL

* minor changes

* removing unwanted information from an error msg
Gabrielopesantos pushed a commit to Gabrielopesantos/vault that referenced this pull request Jun 6, 2022
* Globally scoped MFA method Get/List endpoints

* Adding CL

* minor changes

* removing unwanted information from an error msg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants