-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Globally scoped MFA method Get/List endpoints #15248
Merged
hghaf099
merged 5 commits into
main
from
vault-5993-globally-scoped-mfa-method-get-endpoints
May 17, 2022
Merged
Globally scoped MFA method Get/List endpoints #15248
hghaf099
merged 5 commits into
main
from
vault-5993-globally-scoped-mfa-method-get-endpoints
May 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
approved these changes
May 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I provided one small comment about potentially exposing unwanted information in an error string but otherwise looks good!
hghaf099
added a commit
that referenced
this pull request
May 17, 2022
* Globally scoped MFA method Get/List endpoints * Adding CL * minor changes * removing unwanted information from an error msg
hghaf099
added a commit
that referenced
this pull request
May 17, 2022
Gabrielopesantos
pushed a commit
to Gabrielopesantos/vault
that referenced
this pull request
Jun 6, 2022
* Globally scoped MFA method Get/List endpoints * Adding CL * minor changes * removing unwanted information from an error msg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses VAULT-5993 which is requesting to add a couple of globally scoped endpoints:
/identity/mfa/method/:id
/identity/mfa/method?list=true
A bug is fixed as well where reading operation will return a method of a different type if a valid id is provided.