Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAULT-5887] TypeInt64 support added to OpenApi Spec generation #15104

Merged
merged 3 commits into from
Apr 22, 2022
Merged

[VAULT-5887] TypeInt64 support added to OpenApi Spec generation #15104

merged 3 commits into from
Apr 22, 2022

Conversation

AnPucel
Copy link
Contributor

@AnPucel AnPucel commented Apr 20, 2022 •
edited
Loading

framework.TypeInt64 was not caught when converting to OpenApi types and would result in a confusing warning when calling /v1/sys/internal/specs/openapi

Verified by building Vault and generating an OpenApi spec and verifying we don't have any unknown formats in our spec.

@AnPucel AnPucel requested a review from a team April 20, 2022 20:42
digivava
digivava approved these changes Apr 20, 2022
View reviewed changes
Copy link
Collaborator

@digivava digivava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

averche
averche reviewed Apr 20, 2022
View reviewed changes
Copy link
Contributor

@averche averche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It might be a good idea to add a unit test case for this as well in openapi_test.go

@AnPucel AnPucel requested a review from kalafut April 20, 2022 20:51
@kalafut kalafut removed their request for review April 20, 2022 20:58
@AnPucel AnPucel changed the title TypeInt64 support added to OpenApi Spec generation [VAULT-5887] TypeInt64 support added to OpenApi Spec generation Apr 20, 2022
@AnPucel AnPucel merged commit d569b23 into main Apr 22, 2022
This was referenced Apr 22, 2022
Merged
Merged
Merged
@AnPucel AnPucel deleted the anpucel/OASTypeFix branch April 26, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averche averche averche left review comments

@digivava digivava digivava approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnPucel @digivava @averche