Backport of Custom tooltip for Generated Token Policies form field on auth methods into release/1.8.x #15052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/fix-tooltip/preferably-pro-monarch
branch
from
e2733c8 to
16ff2f7
Compare
hashishaw
previously requested changes
Apr 15, 2022
hellobontempo
dismissed
hashishaw’s stale review
Requested change has been addressed! (And Chelsea is out today, unable to re-review)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #15046 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
This PR intercepts the model on the
generatedItemcomponent to replace thehelpTextfor the auth form field "Generated Token's Policies"Before the help text read: Comma-separated list of policies associated with the user.
However, this field (e.g form field = stringArray) does not accept comma separated lists. We instead want a user to add a row for each new policy. We cannot change the text here because that changes the CLI text which does accept a comma separated list. So instead, we interrupt the component, search for this field type and replace the helpText with the following: Add policies that will apply to the generated token for this user. One policy per row.
This now looks like this:
This change effects TLS Certificates, Userpass, and Kubernetes who have this field. The other auth methods have a different field or no policy field at all.
Will backport to 1.8
See GH issue here.