feature: secrets/auth plugin multiplexing #14946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
force-pushed
the
feat/mux-secrets-auth
branch
from
fe26e7f to
cd229a1
Compare
calvn
reviewed
Apr 20, 2022
fairclothjm
force-pushed
the
feat/mux-secrets-auth
branch
from
cd229a1 to
3adb1c0
Compare
fairclothjm
force-pushed
the
feat/mux-secrets-auth
branch
from
9311683 to
b179ad4
Compare
cleanup instance map and ensure we don't deadlock
move GetMultiplexIDFromContext to pluginutil package fix pluginutil test fix dbplugin ut
update comments
| if err != nil { | ||
| return err | ||
| } | ||
| b.Backend = nb |
There was a problem hiding this comment.
🤔 Do we need to call initialize here too?
There was a problem hiding this comment.
No, that gets called in the respective auth.go and mount.go
There was a problem hiding this comment.
But in the case where a plugin crashes and is restarted i think we'd need to re-initialize, right?
calvn
reviewed
Aug 29, 2022
- update comments - make use of multiplexing boolean and single implementation ID const
austingebauer
approved these changes
Aug 30, 2022
mladlow
reviewed
Aug 31, 2022
| @@ -0,0 +1,3 @@ | |||
| ```release-note:feature | |||
| **Secrets/auth plugin multiplexing**: manage multiple plugin configurations with a single plugin process | |||
There was a problem hiding this comment.
I was reviewing the changelog for 1.12 features, and wasn't sure if the formatting of just:
Plugin Multiplexing:
would be more consistent with other new feature entries from older releases?
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds multiplexing support for secrets/auth plugins.
When multiplexed secrets/auth plugins are configured in Vault, each plugin will only have a single process managing all configurations for that plugin type. This single process will be multiplexed across all Vault namespaces for mounts of this type.
Some changes for the new v5 plugin set:
To test multiplexing
feat/mux-secrets-authbranchServetoServeMultiplexin the plugin's main.go filefeat/mux-secrets-auth