Backport of Show no config warning error bug fix into release/1.10.x #14811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-secure-vault-core
force-pushed
the
backport/ui/bug-fix-config-check/badly-renewing-seahorse
branch
from
147eedf to
da3ed9c
Compare
zofskeez
approved these changes
Mar 31, 2022
Monkeychip
deleted the
backport/ui/bug-fix-config-check/badly-renewing-seahorse
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #14808 to be assessed for backporting due to the inclusion of the label backport/1.10.x.
The below text is copied from the body of the original PR.
This PR correctly set the conditional to only show this warning at the right time, but something with
mountModelalways returned false when called before the save.I also fixed a test that should have been catching this 🤦🏻♀️ (a test I wrote and incorrectly used ok when I should have been checking for the text).