Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Show no config warning error bug fix into release/1.9.x #14810

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #14808 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This PR correctly set the conditional to only show this warning at the right time, but something with mountModel always returned false when called before the save.

I also fixed a test that should have been catching this 🤦🏻‍♀️ (a test I wrote and incorrectly used ok when I should have been checking for the text).

@hashicorp-cla
Copy link

hashicorp-cla commented Mar 31, 2022

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • Monkeychip
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – vault March 31, 2022 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook March 31, 2022 19:08 Inactive
@Monkeychip Monkeychip closed this Mar 31, 2022
@Monkeychip Monkeychip deleted the backport/ui/bug-fix-config-check/seriously-amusing-zebra branch March 31, 2022 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants