UI: add Database static role password rotation #14268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tic-role-pw-rotation
Monkeychip
reviewed
Feb 24, 2022
| @@ -130,4 +130,6 @@ export default Model.extend({ | |||
| canGetCredentials: alias('staticCredentialPath.canRead'), | |||
| databasePath: lazyCapabilities(apiPath`${'backend'}/config/${'database[0]'}`, 'backend', 'database'), | |||
| canUpdateDb: alias('databasePath.canUpdate'), | |||
| rotateRolePath: lazyCapabilities(apiPath`${'backend'}/rotate-role/${'id'}`, 'backend', 'id'), | |||
Monkeychip
approved these changes
Feb 24, 2022
Good question, I ran it by Ivana and she made a note about the toolbar buttons not quite aligning, but we'll handle that in a separate PR since it's a far-reaching change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building off @berciq's work on #11941, this PR adds the ability to rotate Database secret engine static credentials in the UI from both the role list page and role show page.
Options on static type roles now have rotate credentials option
Options on dynamic type roles do not have the option
New toolbar options on static role
