Allow OpenSSH-style key type identifiers #14143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To bring better parity with the changes of hashicorp#14008, wherein we allowed OpenSSH-style key identifiers during generation. When specifying a list of allowed keys, validate against both OpenSSH-style key identifiers and the usual simplified names as well ("rsa" or "ecdsa"). Notably, the PKI secrets engine prefers "ec" over "ecdsa", so we permit both as well. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
force-pushed
the
allow-ssh-keytypes
branch
from
c766816 to
96b1074
Compare
sgmiller
approved these changes
Feb 18, 2022
| { | ||
| "rsa": [2048, 3072, 4096], | ||
| "ec": 256, | ||
| "ecdsa-sha2-nistp521: 0 |
stevendpclark
approved these changes
Feb 18, 2022
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To bring better parity with the changes of #14008, wherein we allowed
OpenSSH-style key identifiers during generation. When specifying a list
of allowed keys, validate against both OpenSSH-style key identifiers
and the usual simplified names as well ("rsa" or "ecdsa"). Notably, the
PKI secrets engine prefers "ec" over "ecdsa", so we permit both as well.
Signed-off-by: Alexander Scheel <[email protected]>