Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kv secret access bug #13872

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fix kv secret access bug #13872

merged 2 commits into from
Feb 2, 2022

Conversation

arnav28
Copy link
Contributor

@arnav28 arnav28 commented Feb 2, 2022

  • Set permissions state when call is successful

@arnav28
Fix kv secret access bug
bcd7739 
- Set permissions state when call is successful
@arnav28
Added changelog
97b6132
@vercel vercel bot temporarily deployed to Preview – vault-storybook February 2, 2022 07:26 Inactive
@vercel vercel bot temporarily deployed to Preview – vault February 2, 2022 07:26 Inactive
Monkeychip
Monkeychip approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This will need to be backported to 1.9, nothing earlier as the KV metadata work was not complete.

@Monkeychip Monkeychip added this to the 1.10 milestone Feb 2, 2022
@arnav28 arnav28 merged commit 81ea900 into main Feb 2, 2022
arnav28 added a commit that referenced this pull request Feb 2, 2022
@arnav28
Fix kv secret access bug (#13872)
fffb91c 
* Fix kv secret access bug

- Set permissions state when call is successful

* Added changelog
arnav28 added a commit that referenced this pull request Feb 2, 2022
@arnav28
Fix kv secret access bug (#13872) (#13880)
37e1752 
* Fix kv secret access bug

- Set permissions state when call is successful

* Added changelog
@arnav28 arnav28 deleted the ui/access-secrets-bug branch February 2, 2022 21:19
@thiskevinwang thiskevinwang mentioned this pull request Apr 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Monkeychip Monkeychip Monkeychip approved these changes

Assignees
No one assigned
Labels
backport ui
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.
2 participants
@arnav28 @Monkeychip