Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip hash bits verification for ed25519 #13254

Merged
merged 3 commits into from
Nov 23, 2021
Merged

skip hash bits verification for ed25519 #13254

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
11fe293
skip hash bits verification for ed25519 #13253
navaneethrameshan Nov 23, 2021
607a007
Add changelog
navaneethrameshan Nov 23, 2021
33bfa26
Update changelog/13254.txt
navaneethrameshan Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/13254.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
Skip signature bits validation for ed25519 curve
navaneethrameshan marked this conversation as resolved.
Show resolved Hide resolved
```
5 changes: 3 additions & 2 deletions sdk/helper/certutil/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,11 +557,12 @@ func ValidateKeyTypeSignatureLength(keyType string, keyBits int, hashBits *int)
// To match previous behavior (and ignoring recommendations of hash
// size to match RSA key sizes), default to SHA-2-256.
*hashBits = 256
} /* else if keyType == "ed25519" {
} else if keyType == "ed25519" {
// No-op; ed25519 and ed448 internally specify their own hash and
// we do not need to select one. Double hashing isn't supported in
// certificate signing.
} */
return nil
}

// Note that this check must come after we've selected a value for
// hashBits above, in the event it was left as the default, but we
Expand Down