Add HTTP PATCH support for KV key metadata #13215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
changed the title
ccapurso
changed the title
HridoyRoy
suggested changes
Dec 16, 2021
go.mod
Outdated
| @@ -108,15 +108,15 @@ require ( | |||
| github.com/hashicorp/vault-plugin-secrets-azure v0.11.2 | |||
| github.com/hashicorp/vault-plugin-secrets-gcp v0.11.0 | |||
| github.com/hashicorp/vault-plugin-secrets-gcpkms v0.10.0 | |||
| github.com/hashicorp/vault-plugin-secrets-kv v0.5.7-0.20211123171606-16933c88368a | |||
| github.com/hashicorp/vault-plugin-secrets-kv v0.5.7-0.20211206210934-74fe79f60b74 | |||
There was a problem hiding this comment.
Were these upgrades intentional? If you wanted to include the upgrades in the other 2 PRs open for review, I think you'd need to re-import after those PRs are merged.
There was a problem hiding this comment.
Yes, the intention is to include the upgrade for vault-plugin-secrets-kv for review. As you mentioned, I plan to re-import after those PRs are merged.
HridoyRoy
approved these changes
Jan 10, 2022
heppu
pushed a commit
to heppu/vault
that referenced
this pull request
Jan 13, 2022
* go get vault-plugin-secrets-kv@vault-4290-patch-metadata * add kv metadata patch command * add changelog entry * success tests for kv metadata patch flags * add more kv metadata patch flags tests * add kv metadata patch cas warning test * add kv-v2 key metadata patch API docs * add kv metadata patch to docs * prevent unintentional field overwriting in kv metadata put cmd * like create/update ops, prevent patch to paths ending in / * fix kv metadata patch cmd in docs * fix flag defaults for kv metadata put * go get vault-plugin-secrets-kv@vault-4290-patch-metadata * fix TestKvMetadataPatchCommand_Flags test * doc fixes * go get vault-plugin-secrets-kv@master; go mod tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #57 for
vault-plugin-secrets-kvintroduces aPatchOperationhandler for the KV<mount>/metadata/:pathendpoint. This PR introduces the CLI commandkv metadata patch. The command will only include fields in the request data that have been provided as flags to prevent unexpectedly clearing them via the patch operation. This was actually an issue that was discovered for thekv metadata putcommand and has been fixed as part of this PR.