Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/Adds pagination to auth methods list #13054

Merged
merged 2 commits into from
Nov 4, 2021

Conversation

hellobontempo
Copy link
Contributor

Fix for #12962 - when lots of auth method groups or users created there is no way to navigate to view the full list.

auth-method-error

With pagination:
auth-method-pagination

@vercel vercel bot temporarily deployed to Preview – vault November 4, 2021 19:02 Inactive
@hellobontempo hellobontempo linked an issue Nov 4, 2021 that may be closed by this pull request
@vercel vercel bot temporarily deployed to Preview – vault-storybook November 4, 2021 19:03 Inactive
@Monkeychip Monkeychip added this to the 1.9.1 milestone Nov 4, 2021
Copy link
Contributor

@Monkeychip Monkeychip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I added the 1.9.1 milestone, just guessing that's where it needs to go, but amend if I'm wrong.

@hellobontempo hellobontempo modified the milestones: 1.9.1, 1.8.6 Nov 4, 2021
@hellobontempo hellobontempo merged commit 61c41fb into main Nov 4, 2021
hellobontempo added a commit that referenced this pull request Nov 4, 2021
* adds pagination to auth methods list

* adds changelog
hellobontempo added a commit that referenced this pull request Nov 4, 2021
* adds pagination to auth methods list

* adds changelog
@hellobontempo hellobontempo deleted the ui/add-pagination-ldap-groups branch November 5, 2021 00:06
hellobontempo added a commit that referenced this pull request Nov 8, 2021
* adds pagination to auth methods list

* adds changelog
hellobontempo added a commit that referenced this pull request Nov 8, 2021
* adds pagination to auth methods list

* adds changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No Pagination Bar for Ldap Group Page
2 participants