Incorporate Ember Flight Icons #12976

zofskeez · 2021-10-29T22:36:46Z

Adds Ember Flight Icons to UI and updates Icon component to use flight icons when available.

Overview

added ember-flight-icons dependency
added babel plugin to import json of icon map to determine whether to use the FlightIcon component or fallback to existing implementation
updated Icon component to display icons from both sets
updated Icon component usages in application to new api and changed names to flight icon set where applicable
added styling to flight icons to align with existing icon style
added tests for new Icon component logic
updated icon story to display mappings to flight set
updated storybook config to insert svg sprite into dom for flight icons

View the Icon story to see a table of the icon mappings by running yarn storybook and then click Icon in the sidebar.

…light icon set when available

…cons not rendering in storybook

hashishaw

Great work so far! Excited to finally be consuming the Flight Icons.

ui/.storybook/config.js

ui/app/models/transit-key.js

hashishaw · 2021-11-02T20:49:59Z

ui/lib/core/addon/templates/components/icon.hbs

+    @name={{@name}}
+    @size={{this.flightIconSize}}
+    class={{this.iconClass}}


Is iconClass still relevant to flight icons, since we pass in the size attribute?

It is in order to keep the styling consistent between icon sets. Currently flight icons only support 16 and 24 for the size param but there are 6 different sizes for the hs-icon class. I created flight-icon.scss to tweak the hs-icon size classes to match as closely as possible which is then applied to the component.

I wrestled with this a bit but wanted to support the size parameter for FlightIcon while still preserving the hs-icon sizing that existed. If it's confusing we could make size private for now and rely on the hs-icon size classes until FlightIcon size becomes more flexible.

I wonder if we should instead conform our sizes to the new standard 🤔 may want to wait for Ivana to weigh in on this one

@ivana-mcconnell what are your thoughts on this? You can see how the sizes are mapped in this commit and here's a breakdown of the number of times the Icon component is used in the app across the various sizes:

s - 7
m - 118
l - 37
xlm - 3
xl - 11
xxl - 1

I'm on board with conforming our sizes to the new standard, but I think that it's worth a pairing session to look at the instances where icons are not 16px or 24px and making adjustments for them, just so we don't end up with something incredibly disproportionate. It looks like that's a total of 22 instances (s, xlm, xl, xxl). Might be a little tedious, but probably worthwhile.

@hashishaw after pairing with Ivana and confirming the new size standards I updated the component and simplified things in this commit.

ui/lib/core/icon-mappings.js

hashishaw · 2021-11-02T20:54:48Z

ui/lib/core/addon/components/icon.js

-    let { size } = this;
+  name: null,
+  sizeClass: 'm', // hs-icon specific
+  size: null, // fight icon specific


Is the default size inherited from Flight Icon? Should we be prescriptive about our default for Flight icons here?

Yes the FlightIcon default is 16. There is a flightIconSize computed property which gets passed to the component that will set the size to either 16 or 24 based on the sizeClass value if size was not provided which is the reason for the null default.

@hashishaw the sizeClass property has been removed and size is now used exclusively with a default of 16 as of this commit.

hashishaw · 2021-11-02T20:56:28Z

ui/tests/integration/components/icon-test.js

+  });
+
+  test('it should render FlightIcon', async function(assert) {
+    assert.expect(5);


What is this?

This ensures that an explicit number of assertions are run within the test, in this case 5. It's a force of habit for me but basically just helps to guard against unexpected assertions or unintended modifications to a test perhaps.

ui/tests/integration/components/icon-test.js

ui/app/templates/components/console/log-error-with-html.hbs

hashishaw

Great work, thank you!

* Rename master key to root key (#13324) * See what it looks like to replace "master key" with "root key". There are two places that would require more challenging code changes: the storage path `core/master`, and its contents (the JSON-serialized EncodedKeyringtructure.) * Restore accidentally deleted line * Add changelog * Update root->recovery * Fix test Co-authored-by: Nick Cabatoff <[email protected]> * Fix typo (#13355) * Add kms_library configuration stanza (#13352) - Add the kms_library configuration stanza to Vault's command/server - Provide validation of keys and general configuration. - Add initial kms_library configuration documentation - Attempt at startup to verify we can read the configured HSM Library - Hook in KmsLibrary config into the Validate to detect typo/unused keys * modifed note (#13351) * Incorporate Ember Flight Icons (#12976) * adds ember-flight-icons dependecy * adds inline-json-import babel plugin * adds flight icon styling * updates Icon component to support flight icons * updates Icon component usages to new api and updates name values to flight icon set when available * fixes tests * updates icon story with flight mappings and fixes issue with flight icons not rendering in storybook * adds changelog * fixes typo in sign action glyph name in transit-key model * adds comments to icon-map * updates Icon component to use only supported flight icon sizes * adds icon transform codemod * updates icon transform formatting to handle edge case * runs icon transform on templates * updates Icon usage in toolbar-filter md and story * updates tests * docs: winsvc update recommendations (#13280) * docs: update custom database sample code (#13211) * clarify more sink options (#12586) * Update @hashicorp/react-hashi-stack-menu (#13354) * Docs to clarify k8s auth options with short-lived tokens (#13275) * Rework 1.21 content into one heading and add note at top * Add notes about extended k8s token duration * Add example of ClusterRoleBinding for using client JWTs * Adds support for SHA-3 to transit (#13367) * Adding support for SHA3 in the transit backend. * Adds SHA-3 tests for transit sign/verify path. Adds SHA-3 tests for logical system tools path hash functionality. Updates documentation to include SHA-3 algorithms in system tools path hashing. * Adds changelog entry. Co-authored-by: robison jacka <[email protected]> * agent/cache: differentiate open log messages (#13362) Changes the error output for the second open of the persistent cache file, to differentiate it from the c.UI.Error message for the initial open of the cache file, just to make it easier to tell where a problem occurred. * Warn user supplying nonce values in FIPS mode for transit encryption requests (#13366) * Warn user supplying nonce values in FIPS mode for transit encryption requests - Send back a warning within the response if an end-user supplies nonce values that we use within the various transit encrypt apis. - We do not send a warning if an end-user supplies a nonce value but we don't use it. - Affected api methods are encrypt, rewrap and datakey - The warning is only sent when we are operating in FIPS mode. * [VAULT-3252] Add entity-alias behavior change to docs (#13370) * Add entity-alias behavior change to docs * Add upgrade note about entity-alias mapping change * Rename 1.7-9 upgrade pages, shuffle upgrade note position * Update website/content/partials/entity-alias-mapping.mdx Co-authored-by: Meggie <[email protected]> * Add incorrect policy issue to the docs * Add example about entity-alias restriction Co-authored-by: Meggie <[email protected]> * VAULT-1564 report in-flight requests (#13024) * VAULT-1564 report in-flight requests * adding a changelog * Changing some variable names and fixing comments * minor style change * adding unauthenticated support for in-flight-req * adding documentation for the listener.profiling stanza * adding an atomic counter for the inflight requests addressing comments * addressing comments * logging completed requests * fixing a test * providing log_requests_info as a config option to determine at which level requests should be logged * removing a member and a method from the StatusHeaderResponseWriter struct * adding api docks * revert changes in NewHTTPResponseWriter * Fix logging invalid log_requests_info value * Addressing comments * Fixing a test * use an tomic value for logRequestsInfo, and moving the CreateClientID function to Core * fixing go.sum * minor refactoring * protecting InFlightRequests from data race * another try on fixing a data race * another try to fix a data race * addressing comments * fixing couple of tests * changing log_requests_info to log_requests_level * minor style change * fixing a test * removing the lock in InFlightRequests * use single-argument form for interface assertion * adding doc for the new configuration paramter * adding the new doc to the nav data file * minor fix * auth/jwt: Update plugin to v0.11.3 (#13365) * auth/jwt: Update plugin to v0.11.3 * add changelog * changelog++ * Update alert banner (#13375) * Updating website for 1.9.1 (#13378) * Use os.Hostname instead of a dependency that doesn't work on OpenBSD. (#13389) * Remove another use gopsutil/host. (#13390) * CLI changes for new mount tune config parameter allowed_managed_keys (#13255) * CLI changes for new mount tune config parameter allowed_managed_keys * Correct allowed_managed_keys description in auth and secrets * Documentation update for secrets and removed changes for auth * Add changelog and remove documentation changes for auth * removed changelog * Correct the field description * auth/jwt: update changelog for pkce improvement (#13392) * Fix test validating convergent encryption behaviour across key types (#13371) - The test was attempting to test the convergent encryption behaviour with several key types but the common function never used the passed in key type. So we ran the test with the default aes256-gcm96 only. * Fix managed namespace test (#13394) * Fix managed namespace test * Remove log * Some changelog tidying for 1.10 preview (#13385) * Some changelog tidying for 1.10 preview * PR accounted for by different CL entry * changelog++ Working on a new workflow for generating the preview so I thought I'd leave a note that it's still coming. * UI/fix client count partial (#13396) * Initial fix * Add fallback zero values * Add changelog * Fix client count current test * Support clearing an identity alias' custom_metadata (#13395) * Support clearing an identity alias' custom_metadata Previously, an update to an entity alias supported updating the custom_metadata as long as the update was not empty, which makes it impossible to clear the metadata values completely. Fixes: - empty custom_metadata parameters are honoured on entity alias update - update related tests - drop dependency on mapstructure - reformat with gofumpt * Docs: fix invalid link in the kubernetes auth api doc. (#13399) * Clean up whitespace * auth/azure: add note about debug env (#13405) * auth/azure: add note about debug env * Update azure.mdx * Update azure.mdx * Add universal default key_bits value for PKI endpoints (#13080) * Allow universal default for key_bits This allows the key_bits field to take a universal default value, 0, which, depending on key_type, gets adjusted appropriately into a specific default value (rsa->2048, ec->256, ignored under ed25519). Signed-off-by: Alexander Scheel <[email protected]> * Handle universal default key size in certutil Also move RSA < 2048 error message into certutil directly, instead of in ca_util/path_roles. Signed-off-by: Alexander Scheel <[email protected]> * Add missing RSA key sizes to pki/backend_test.go Signed-off-by: Alexander Scheel <[email protected]> * Switch to returning updated values When determining the default, don't pass in pointer types, but instead return the newly updated value. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> * Re-add fix for ed25519 from #13254 Ed25519 internally specifies a hash length; by changing the default from 256 to 0, we fail validation in ValidateSignatureLength(...) unless we specify the key algorithm. Signed-off-by: Alexander Scheel <[email protected]> * Fix logging statement using formatting args (#13407) * Add docs about path param restrictions (#13413) * Add docs about path param restrictions * Update website/content/api-docs/auth/userpass.mdx Co-authored-by: Loann Le <[email protected]> * Update with review suggestion Co-authored-by: Loann Le <[email protected]> * Update raftautosnapshots.mdx (#13412) * Main go version bump (#13408) * Go 1.17.2 -> 1.17.5 * Switching to cimg * Bump yarn cache key version so that it uses the new disk layout we've adopted for using cimg/go. (#13420) * Add vault-api module (#13048) * crt main fix for ecr tag (#13425) * Add no-op method setupManagedKeyRegistry(). (#13433) * github auth: use org id to verify creds (#13332) * github auth: use org id to verify creds * add check for required org param; add test case * update UTs * add nil check for org * add changelog * fix typo in ut * set org ID if it is unset; add more ut coverage * add optional organization_id * move client instantiation * refactor parse URL; add UT for setting org ID * fix comment in UT * add nil check * don't update org name on change; return warning * refactor verifyCredentials * error when unable to fetch org ID on config write; add warnings * fix bug in log message * update UT and small refactor * update comments and log msg * use getter for org ID Co-authored-by: Jim Kalafut <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Harsimran Singh Maan <[email protected]> Co-authored-by: Steven Clark <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: mickael-hc <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Mike Green <[email protected]> Co-authored-by: Noel Quiles <[email protected]> Co-authored-by: Tom Proctor <[email protected]> Co-authored-by: Matt Schultz <[email protected]> Co-authored-by: robison jacka <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Pratyoy Mukhopadhyay <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: hghaf099 <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Brandon Romano <[email protected]> Co-authored-by: divyapola5 <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Mark Lewis <[email protected]> Co-authored-by: Sai Hemanth Bheemreddy <[email protected]> Co-authored-by: Kyle Penfound <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]>

* UI/total client usage (#13359) * blah * setup * clean up * rename history to dashboard * clean up * Styling fixes (#13369) * styling * clean up * UI/ horizontal bar chart component (#13361) * horizontal bar chart component * adds horizontal chart to dashboard file * add export class * yarn install d3 array * yarn install d3 array * adds data subtext to chart * update naming to plural charts" * updates css grid to 6 columns" * UI/tooltip (#13397) * working state * stuff * adds month tick marks and sort of y-axis, but y scale still messed up * moves y scale so zero shows again * fixes translating constants * format numbers y axis * actually fixes viewbox * styling for x and y axis plus gridlines * clean up * separates grid types based on content Co-authored-by: Claire Bontempo <[email protected]> * Styling and legend component (#13430) * styling * cleanup * UI/ Double horizontal bar charts (#13398) * add descriptions and styling to side by side charts * add border below horizontal charts * starts legend styling * center legend * add to do * add hover actions/event listeners * UI/merge main (#13436) * Rename master key to root key (#13324) * See what it looks like to replace "master key" with "root key". There are two places that would require more challenging code changes: the storage path `core/master`, and its contents (the JSON-serialized EncodedKeyringtructure.) * Restore accidentally deleted line * Add changelog * Update root->recovery * Fix test Co-authored-by: Nick Cabatoff <[email protected]> * Fix typo (#13355) * Add kms_library configuration stanza (#13352) - Add the kms_library configuration stanza to Vault's command/server - Provide validation of keys and general configuration. - Add initial kms_library configuration documentation - Attempt at startup to verify we can read the configured HSM Library - Hook in KmsLibrary config into the Validate to detect typo/unused keys * modifed note (#13351) * Incorporate Ember Flight Icons (#12976) * adds ember-flight-icons dependecy * adds inline-json-import babel plugin * adds flight icon styling * updates Icon component to support flight icons * updates Icon component usages to new api and updates name values to flight icon set when available * fixes tests * updates icon story with flight mappings and fixes issue with flight icons not rendering in storybook * adds changelog * fixes typo in sign action glyph name in transit-key model * adds comments to icon-map * updates Icon component to use only supported flight icon sizes * adds icon transform codemod * updates icon transform formatting to handle edge case * runs icon transform on templates * updates Icon usage in toolbar-filter md and story * updates tests * docs: winsvc update recommendations (#13280) * docs: update custom database sample code (#13211) * clarify more sink options (#12586) * Update @hashicorp/react-hashi-stack-menu (#13354) * Docs to clarify k8s auth options with short-lived tokens (#13275) * Rework 1.21 content into one heading and add note at top * Add notes about extended k8s token duration * Add example of ClusterRoleBinding for using client JWTs * Adds support for SHA-3 to transit (#13367) * Adding support for SHA3 in the transit backend. * Adds SHA-3 tests for transit sign/verify path. Adds SHA-3 tests for logical system tools path hash functionality. Updates documentation to include SHA-3 algorithms in system tools path hashing. * Adds changelog entry. Co-authored-by: robison jacka <[email protected]> * agent/cache: differentiate open log messages (#13362) Changes the error output for the second open of the persistent cache file, to differentiate it from the c.UI.Error message for the initial open of the cache file, just to make it easier to tell where a problem occurred. * Warn user supplying nonce values in FIPS mode for transit encryption requests (#13366) * Warn user supplying nonce values in FIPS mode for transit encryption requests - Send back a warning within the response if an end-user supplies nonce values that we use within the various transit encrypt apis. - We do not send a warning if an end-user supplies a nonce value but we don't use it. - Affected api methods are encrypt, rewrap and datakey - The warning is only sent when we are operating in FIPS mode. * [VAULT-3252] Add entity-alias behavior change to docs (#13370) * Add entity-alias behavior change to docs * Add upgrade note about entity-alias mapping change * Rename 1.7-9 upgrade pages, shuffle upgrade note position * Update website/content/partials/entity-alias-mapping.mdx Co-authored-by: Meggie <[email protected]> * Add incorrect policy issue to the docs * Add example about entity-alias restriction Co-authored-by: Meggie <[email protected]> * VAULT-1564 report in-flight requests (#13024) * VAULT-1564 report in-flight requests * adding a changelog * Changing some variable names and fixing comments * minor style change * adding unauthenticated support for in-flight-req * adding documentation for the listener.profiling stanza * adding an atomic counter for the inflight requests addressing comments * addressing comments * logging completed requests * fixing a test * providing log_requests_info as a config option to determine at which level requests should be logged * removing a member and a method from the StatusHeaderResponseWriter struct * adding api docks * revert changes in NewHTTPResponseWriter * Fix logging invalid log_requests_info value * Addressing comments * Fixing a test * use an tomic value for logRequestsInfo, and moving the CreateClientID function to Core * fixing go.sum * minor refactoring * protecting InFlightRequests from data race * another try on fixing a data race * another try to fix a data race * addressing comments * fixing couple of tests * changing log_requests_info to log_requests_level * minor style change * fixing a test * removing the lock in InFlightRequests * use single-argument form for interface assertion * adding doc for the new configuration paramter * adding the new doc to the nav data file * minor fix * auth/jwt: Update plugin to v0.11.3 (#13365) * auth/jwt: Update plugin to v0.11.3 * add changelog * changelog++ * Update alert banner (#13375) * Updating website for 1.9.1 (#13378) * Use os.Hostname instead of a dependency that doesn't work on OpenBSD. (#13389) * Remove another use gopsutil/host. (#13390) * CLI changes for new mount tune config parameter allowed_managed_keys (#13255) * CLI changes for new mount tune config parameter allowed_managed_keys * Correct allowed_managed_keys description in auth and secrets * Documentation update for secrets and removed changes for auth * Add changelog and remove documentation changes for auth * removed changelog * Correct the field description * auth/jwt: update changelog for pkce improvement (#13392) * Fix test validating convergent encryption behaviour across key types (#13371) - The test was attempting to test the convergent encryption behaviour with several key types but the common function never used the passed in key type. So we ran the test with the default aes256-gcm96 only. * Fix managed namespace test (#13394) * Fix managed namespace test * Remove log * Some changelog tidying for 1.10 preview (#13385) * Some changelog tidying for 1.10 preview * PR accounted for by different CL entry * changelog++ Working on a new workflow for generating the preview so I thought I'd leave a note that it's still coming. * UI/fix client count partial (#13396) * Initial fix * Add fallback zero values * Add changelog * Fix client count current test * Support clearing an identity alias' custom_metadata (#13395) * Support clearing an identity alias' custom_metadata Previously, an update to an entity alias supported updating the custom_metadata as long as the update was not empty, which makes it impossible to clear the metadata values completely. Fixes: - empty custom_metadata parameters are honoured on entity alias update - update related tests - drop dependency on mapstructure - reformat with gofumpt * Docs: fix invalid link in the kubernetes auth api doc. (#13399) * Clean up whitespace * auth/azure: add note about debug env (#13405) * auth/azure: add note about debug env * Update azure.mdx * Update azure.mdx * Add universal default key_bits value for PKI endpoints (#13080) * Allow universal default for key_bits This allows the key_bits field to take a universal default value, 0, which, depending on key_type, gets adjusted appropriately into a specific default value (rsa->2048, ec->256, ignored under ed25519). Signed-off-by: Alexander Scheel <[email protected]> * Handle universal default key size in certutil Also move RSA < 2048 error message into certutil directly, instead of in ca_util/path_roles. Signed-off-by: Alexander Scheel <[email protected]> * Add missing RSA key sizes to pki/backend_test.go Signed-off-by: Alexander Scheel <[email protected]> * Switch to returning updated values When determining the default, don't pass in pointer types, but instead return the newly updated value. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> * Re-add fix for ed25519 from #13254 Ed25519 internally specifies a hash length; by changing the default from 256 to 0, we fail validation in ValidateSignatureLength(...) unless we specify the key algorithm. Signed-off-by: Alexander Scheel <[email protected]> * Fix logging statement using formatting args (#13407) * Add docs about path param restrictions (#13413) * Add docs about path param restrictions * Update website/content/api-docs/auth/userpass.mdx Co-authored-by: Loann Le <[email protected]> * Update with review suggestion Co-authored-by: Loann Le <[email protected]> * Update raftautosnapshots.mdx (#13412) * Main go version bump (#13408) * Go 1.17.2 -> 1.17.5 * Switching to cimg * Bump yarn cache key version so that it uses the new disk layout we've adopted for using cimg/go. (#13420) * Add vault-api module (#13048) * crt main fix for ecr tag (#13425) * Add no-op method setupManagedKeyRegistry(). (#13433) * github auth: use org id to verify creds (#13332) * github auth: use org id to verify creds * add check for required org param; add test case * update UTs * add nil check for org * add changelog * fix typo in ut * set org ID if it is unset; add more ut coverage * add optional organization_id * move client instantiation * refactor parse URL; add UT for setting org ID * fix comment in UT * add nil check * don't update org name on change; return warning * refactor verifyCredentials * error when unable to fetch org ID on config write; add warnings * fix bug in log message * update UT and small refactor * update comments and log msg * use getter for org ID Co-authored-by: Jim Kalafut <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Harsimran Singh Maan <[email protected]> Co-authored-by: Steven Clark <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: mickael-hc <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Mike Green <[email protected]> Co-authored-by: Noel Quiles <[email protected]> Co-authored-by: Tom Proctor <[email protected]> Co-authored-by: Matt Schultz <[email protected]> Co-authored-by: robison jacka <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Pratyoy Mukhopadhyay <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: hghaf099 <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Brandon Romano <[email protected]> Co-authored-by: divyapola5 <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Mark Lewis <[email protected]> Co-authored-by: Sai Hemanth Bheemreddy <[email protected]> Co-authored-by: Kyle Penfound <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]> * UI/chart legend (#13437) * fixes axes lines blend * add pixel conversions to variable css file * reorganizes css file * adds legend * fixes scales and makes room for legend * fixes grid for dual charts * made grid responsive * fixes legend styling * fixes legend, removes ticks and fixes scale * adjusts tooltip target * un-comment mouse events * remove console log * UI/ Client counts range (running total component) (#13477) * grid for stacked charts * pass in data as arg from parent * pull out vertical bar chart component * refactor to use vertical bar chart component * remove any chart handling stuff from parent * rename variables * refactor horizontal bar chart into separate component * move descriptions to inside template (not passed in) * constructs attribution copy * add sample response to mirage config * change indenting * rename to MonthlyUsage * change name to running totals * rename variable * finishes line chart * pull constants to util * cleanup add todos * fix formatNumbers return" * comments and cleanup * adds tooltip to line chart * make cover area larger * fixes tooltip styling * adds tooltip styling" * adds tooltip modal to horizontal chart * finishes tooltip for horizontal chart * remove click event arg * merges main and fixes conflicts * bumps yarn.lock * linting fix * clean up go files and changelog * more clean up * remove changelog * fix * update component documentation for jsdocs * removing test to see if that helps with browserstack * remove new packages to test dep failure * add ember-modal-dialog * add ember-tether * add ember-tether * fixes mirage config file - merge conflict issue * remove general spacing variable Co-authored-by: claire bontempo <[email protected]> Co-authored-by: Claire Bontempo <[email protected]> Co-authored-by: Jim Kalafut <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Harsimran Singh Maan <[email protected]> Co-authored-by: Steven Clark <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: mickael-hc <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Mike Green <[email protected]> Co-authored-by: Noel Quiles <[email protected]> Co-authored-by: Tom Proctor <[email protected]> Co-authored-by: Matt Schultz <[email protected]> Co-authored-by: robison jacka <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Pratyoy Mukhopadhyay <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: hghaf099 <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Brandon Romano <[email protected]> Co-authored-by: divyapola5 <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Mark Lewis <[email protected]> Co-authored-by: Sai Hemanth Bheemreddy <[email protected]> Co-authored-by: Kyle Penfound <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]>

* adds ember-flight-icons dependecy * adds inline-json-import babel plugin * adds flight icon styling * updates Icon component to support flight icons * updates Icon component usages to new api and updates name values to flight icon set when available * fixes tests * updates icon story with flight mappings and fixes issue with flight icons not rendering in storybook * adds changelog * fixes typo in sign action glyph name in transit-key model * adds comments to icon-map * updates Icon component to use only supported flight icon sizes * adds icon transform codemod * updates icon transform formatting to handle edge case * runs icon transform on templates * updates Icon usage in toolbar-filter md and story * updates tests

* UI/total client usage (hashicorp#13359) * blah * setup * clean up * rename history to dashboard * clean up * Styling fixes (hashicorp#13369) * styling * clean up * UI/ horizontal bar chart component (hashicorp#13361) * horizontal bar chart component * adds horizontal chart to dashboard file * add export class * yarn install d3 array * yarn install d3 array * adds data subtext to chart * update naming to plural charts" * updates css grid to 6 columns" * UI/tooltip (hashicorp#13397) * working state * stuff * adds month tick marks and sort of y-axis, but y scale still messed up * moves y scale so zero shows again * fixes translating constants * format numbers y axis * actually fixes viewbox * styling for x and y axis plus gridlines * clean up * separates grid types based on content Co-authored-by: Claire Bontempo <[email protected]> * Styling and legend component (hashicorp#13430) * styling * cleanup * UI/ Double horizontal bar charts (hashicorp#13398) * add descriptions and styling to side by side charts * add border below horizontal charts * starts legend styling * center legend * add to do * add hover actions/event listeners * UI/merge main (hashicorp#13436) * Rename master key to root key (hashicorp#13324) * See what it looks like to replace "master key" with "root key". There are two places that would require more challenging code changes: the storage path `core/master`, and its contents (the JSON-serialized EncodedKeyringtructure.) * Restore accidentally deleted line * Add changelog * Update root->recovery * Fix test Co-authored-by: Nick Cabatoff <[email protected]> * Fix typo (hashicorp#13355) * Add kms_library configuration stanza (hashicorp#13352) - Add the kms_library configuration stanza to Vault's command/server - Provide validation of keys and general configuration. - Add initial kms_library configuration documentation - Attempt at startup to verify we can read the configured HSM Library - Hook in KmsLibrary config into the Validate to detect typo/unused keys * modifed note (hashicorp#13351) * Incorporate Ember Flight Icons (hashicorp#12976) * adds ember-flight-icons dependecy * adds inline-json-import babel plugin * adds flight icon styling * updates Icon component to support flight icons * updates Icon component usages to new api and updates name values to flight icon set when available * fixes tests * updates icon story with flight mappings and fixes issue with flight icons not rendering in storybook * adds changelog * fixes typo in sign action glyph name in transit-key model * adds comments to icon-map * updates Icon component to use only supported flight icon sizes * adds icon transform codemod * updates icon transform formatting to handle edge case * runs icon transform on templates * updates Icon usage in toolbar-filter md and story * updates tests * docs: winsvc update recommendations (hashicorp#13280) * docs: update custom database sample code (hashicorp#13211) * clarify more sink options (hashicorp#12586) * Update @hashicorp/react-hashi-stack-menu (hashicorp#13354) * Docs to clarify k8s auth options with short-lived tokens (hashicorp#13275) * Rework 1.21 content into one heading and add note at top * Add notes about extended k8s token duration * Add example of ClusterRoleBinding for using client JWTs * Adds support for SHA-3 to transit (hashicorp#13367) * Adding support for SHA3 in the transit backend. * Adds SHA-3 tests for transit sign/verify path. Adds SHA-3 tests for logical system tools path hash functionality. Updates documentation to include SHA-3 algorithms in system tools path hashing. * Adds changelog entry. Co-authored-by: robison jacka <[email protected]> * agent/cache: differentiate open log messages (hashicorp#13362) Changes the error output for the second open of the persistent cache file, to differentiate it from the c.UI.Error message for the initial open of the cache file, just to make it easier to tell where a problem occurred. * Warn user supplying nonce values in FIPS mode for transit encryption requests (hashicorp#13366) * Warn user supplying nonce values in FIPS mode for transit encryption requests - Send back a warning within the response if an end-user supplies nonce values that we use within the various transit encrypt apis. - We do not send a warning if an end-user supplies a nonce value but we don't use it. - Affected api methods are encrypt, rewrap and datakey - The warning is only sent when we are operating in FIPS mode. * [VAULT-3252] Add entity-alias behavior change to docs (hashicorp#13370) * Add entity-alias behavior change to docs * Add upgrade note about entity-alias mapping change * Rename 1.7-9 upgrade pages, shuffle upgrade note position * Update website/content/partials/entity-alias-mapping.mdx Co-authored-by: Meggie <[email protected]> * Add incorrect policy issue to the docs * Add example about entity-alias restriction Co-authored-by: Meggie <[email protected]> * VAULT-1564 report in-flight requests (hashicorp#13024) * VAULT-1564 report in-flight requests * adding a changelog * Changing some variable names and fixing comments * minor style change * adding unauthenticated support for in-flight-req * adding documentation for the listener.profiling stanza * adding an atomic counter for the inflight requests addressing comments * addressing comments * logging completed requests * fixing a test * providing log_requests_info as a config option to determine at which level requests should be logged * removing a member and a method from the StatusHeaderResponseWriter struct * adding api docks * revert changes in NewHTTPResponseWriter * Fix logging invalid log_requests_info value * Addressing comments * Fixing a test * use an tomic value for logRequestsInfo, and moving the CreateClientID function to Core * fixing go.sum * minor refactoring * protecting InFlightRequests from data race * another try on fixing a data race * another try to fix a data race * addressing comments * fixing couple of tests * changing log_requests_info to log_requests_level * minor style change * fixing a test * removing the lock in InFlightRequests * use single-argument form for interface assertion * adding doc for the new configuration paramter * adding the new doc to the nav data file * minor fix * auth/jwt: Update plugin to v0.11.3 (hashicorp#13365) * auth/jwt: Update plugin to v0.11.3 * add changelog * changelog++ * Update alert banner (hashicorp#13375) * Updating website for 1.9.1 (hashicorp#13378) * Use os.Hostname instead of a dependency that doesn't work on OpenBSD. (hashicorp#13389) * Remove another use gopsutil/host. (hashicorp#13390) * CLI changes for new mount tune config parameter allowed_managed_keys (hashicorp#13255) * CLI changes for new mount tune config parameter allowed_managed_keys * Correct allowed_managed_keys description in auth and secrets * Documentation update for secrets and removed changes for auth * Add changelog and remove documentation changes for auth * removed changelog * Correct the field description * auth/jwt: update changelog for pkce improvement (hashicorp#13392) * Fix test validating convergent encryption behaviour across key types (hashicorp#13371) - The test was attempting to test the convergent encryption behaviour with several key types but the common function never used the passed in key type. So we ran the test with the default aes256-gcm96 only. * Fix managed namespace test (hashicorp#13394) * Fix managed namespace test * Remove log * Some changelog tidying for 1.10 preview (hashicorp#13385) * Some changelog tidying for 1.10 preview * PR accounted for by different CL entry * changelog++ Working on a new workflow for generating the preview so I thought I'd leave a note that it's still coming. * UI/fix client count partial (hashicorp#13396) * Initial fix * Add fallback zero values * Add changelog * Fix client count current test * Support clearing an identity alias' custom_metadata (hashicorp#13395) * Support clearing an identity alias' custom_metadata Previously, an update to an entity alias supported updating the custom_metadata as long as the update was not empty, which makes it impossible to clear the metadata values completely. Fixes: - empty custom_metadata parameters are honoured on entity alias update - update related tests - drop dependency on mapstructure - reformat with gofumpt * Docs: fix invalid link in the kubernetes auth api doc. (hashicorp#13399) * Clean up whitespace * auth/azure: add note about debug env (hashicorp#13405) * auth/azure: add note about debug env * Update azure.mdx * Update azure.mdx * Add universal default key_bits value for PKI endpoints (hashicorp#13080) * Allow universal default for key_bits This allows the key_bits field to take a universal default value, 0, which, depending on key_type, gets adjusted appropriately into a specific default value (rsa->2048, ec->256, ignored under ed25519). Signed-off-by: Alexander Scheel <[email protected]> * Handle universal default key size in certutil Also move RSA < 2048 error message into certutil directly, instead of in ca_util/path_roles. Signed-off-by: Alexander Scheel <[email protected]> * Add missing RSA key sizes to pki/backend_test.go Signed-off-by: Alexander Scheel <[email protected]> * Switch to returning updated values When determining the default, don't pass in pointer types, but instead return the newly updated value. Signed-off-by: Alexander Scheel <[email protected]> * Add changelog entry Signed-off-by: Alexander Scheel <[email protected]> * Re-add fix for ed25519 from hashicorp#13254 Ed25519 internally specifies a hash length; by changing the default from 256 to 0, we fail validation in ValidateSignatureLength(...) unless we specify the key algorithm. Signed-off-by: Alexander Scheel <[email protected]> * Fix logging statement using formatting args (hashicorp#13407) * Add docs about path param restrictions (hashicorp#13413) * Add docs about path param restrictions * Update website/content/api-docs/auth/userpass.mdx Co-authored-by: Loann Le <[email protected]> * Update with review suggestion Co-authored-by: Loann Le <[email protected]> * Update raftautosnapshots.mdx (hashicorp#13412) * Main go version bump (hashicorp#13408) * Go 1.17.2 -> 1.17.5 * Switching to cimg * Bump yarn cache key version so that it uses the new disk layout we've adopted for using cimg/go. (hashicorp#13420) * Add vault-api module (hashicorp#13048) * crt main fix for ecr tag (hashicorp#13425) * Add no-op method setupManagedKeyRegistry(). (hashicorp#13433) * github auth: use org id to verify creds (hashicorp#13332) * github auth: use org id to verify creds * add check for required org param; add test case * update UTs * add nil check for org * add changelog * fix typo in ut * set org ID if it is unset; add more ut coverage * add optional organization_id * move client instantiation * refactor parse URL; add UT for setting org ID * fix comment in UT * add nil check * don't update org name on change; return warning * refactor verifyCredentials * error when unable to fetch org ID on config write; add warnings * fix bug in log message * update UT and small refactor * update comments and log msg * use getter for org ID Co-authored-by: Jim Kalafut <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Harsimran Singh Maan <[email protected]> Co-authored-by: Steven Clark <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: mickael-hc <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Mike Green <[email protected]> Co-authored-by: Noel Quiles <[email protected]> Co-authored-by: Tom Proctor <[email protected]> Co-authored-by: Matt Schultz <[email protected]> Co-authored-by: robison jacka <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Pratyoy Mukhopadhyay <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: hghaf099 <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Brandon Romano <[email protected]> Co-authored-by: divyapola5 <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Mark Lewis <[email protected]> Co-authored-by: Sai Hemanth Bheemreddy <[email protected]> Co-authored-by: Kyle Penfound <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]> * UI/chart legend (hashicorp#13437) * fixes axes lines blend * add pixel conversions to variable css file * reorganizes css file * adds legend * fixes scales and makes room for legend * fixes grid for dual charts * made grid responsive * fixes legend styling * fixes legend, removes ticks and fixes scale * adjusts tooltip target * un-comment mouse events * remove console log * UI/ Client counts range (running total component) (hashicorp#13477) * grid for stacked charts * pass in data as arg from parent * pull out vertical bar chart component * refactor to use vertical bar chart component * remove any chart handling stuff from parent * rename variables * refactor horizontal bar chart into separate component * move descriptions to inside template (not passed in) * constructs attribution copy * add sample response to mirage config * change indenting * rename to MonthlyUsage * change name to running totals * rename variable * finishes line chart * pull constants to util * cleanup add todos * fix formatNumbers return" * comments and cleanup * adds tooltip to line chart * make cover area larger * fixes tooltip styling * adds tooltip styling" * adds tooltip modal to horizontal chart * finishes tooltip for horizontal chart * remove click event arg * merges main and fixes conflicts * bumps yarn.lock * linting fix * clean up go files and changelog * more clean up * remove changelog * fix * update component documentation for jsdocs * removing test to see if that helps with browserstack * remove new packages to test dep failure * add ember-modal-dialog * add ember-tether * add ember-tether * fixes mirage config file - merge conflict issue * remove general spacing variable Co-authored-by: claire bontempo <[email protected]> Co-authored-by: Claire Bontempo <[email protected]> Co-authored-by: Jim Kalafut <[email protected]> Co-authored-by: Nick Cabatoff <[email protected]> Co-authored-by: Harsimran Singh Maan <[email protected]> Co-authored-by: Steven Clark <[email protected]> Co-authored-by: Loann Le <[email protected]> Co-authored-by: Jordan Reimer <[email protected]> Co-authored-by: mickael-hc <[email protected]> Co-authored-by: Calvin Leung Huang <[email protected]> Co-authored-by: Mike Green <[email protected]> Co-authored-by: Noel Quiles <[email protected]> Co-authored-by: Tom Proctor <[email protected]> Co-authored-by: Matt Schultz <[email protected]> Co-authored-by: robison jacka <[email protected]> Co-authored-by: Theron Voran <[email protected]> Co-authored-by: Pratyoy Mukhopadhyay <[email protected]> Co-authored-by: Meggie <[email protected]> Co-authored-by: hghaf099 <[email protected]> Co-authored-by: John-Michael Faircloth <[email protected]> Co-authored-by: Brandon Romano <[email protected]> Co-authored-by: divyapola5 <[email protected]> Co-authored-by: Chelsea Shaw <[email protected]> Co-authored-by: Ben Ash <[email protected]> Co-authored-by: Jason O'Donnell <[email protected]> Co-authored-by: Alexander Scheel <[email protected]> Co-authored-by: Mark Lewis <[email protected]> Co-authored-by: Sai Hemanth Bheemreddy <[email protected]> Co-authored-by: Kyle Penfound <[email protected]> Co-authored-by: Victor Rodriguez <[email protected]>

zofskeez added 6 commits October 26, 2021 15:26

adds ember-flight-icons dependecy

c5c9327

adds inline-json-import babel plugin

995fd7a

adds flight icon styling

a1fb58d

updates Icon component to support flight icons

9bc7e78

updates Icon component usages to new api and updates name values to f…

74135cc

…light icon set when available

fixes tests

54b1a30

vercel bot temporarily deployed to Preview – vault November 1, 2021 16:31 Inactive

vercel bot deployed to Preview – vault-storybook November 1, 2021 16:31 View deployment

updates icon story with flight mappings and fixes issue with flight i…

7346c19

…cons not rendering in storybook

vercel bot deployed to Preview – vault-storybook November 2, 2021 19:34 View deployment

vercel bot temporarily deployed to Preview – vault November 2, 2021 19:34 Inactive

zofskeez added the ui label Nov 2, 2021

merges main and fixes conflict

199cdc6

vercel bot deployed to Preview – vault November 2, 2021 20:17 View deployment

vercel bot deployed to Preview – vault-storybook November 2, 2021 20:17 View deployment

adds changelog

4aa0c6d

vercel bot temporarily deployed to Preview – vault November 2, 2021 20:24 Inactive

vercel bot temporarily deployed to Preview – vault-storybook November 2, 2021 20:28 Inactive

hashishaw suggested changes Nov 2, 2021

View reviewed changes

zofskeez added 2 commits November 3, 2021 08:50

fixes typo in sign action glyph name in transit-key model

7274d87

adds comments to icon-map

365cdd9

vercel bot temporarily deployed to Preview – vault November 3, 2021 14:58 Inactive

vercel bot deployed to Preview – vault-storybook November 3, 2021 14:58 View deployment

zofskeez requested a review from hashishaw November 3, 2021 21:44

zofskeez added 6 commits November 24, 2021 16:27

updates Icon component to use only supported flight icon sizes

5aa1cd3

adds icon transform codemod

065c46f

merges main and resolves conflict

090a33b

updates icon transform formatting to handle edge case

127e85d

runs icon transform on templates

d474552

updates Icon usage in toolbar-filter md and story

affb4fc

vercel bot temporarily deployed to Preview – vault November 25, 2021 01:07 Inactive

vercel bot deployed to Preview – vault-storybook November 25, 2021 01:07 View deployment

updates tests

128fa99

vercel bot temporarily deployed to Preview – vault December 6, 2021 16:42 Inactive

vercel bot deployed to Preview – vault-storybook December 6, 2021 16:42 View deployment

hashishaw approved these changes Dec 6, 2021

View reviewed changes

amyrlam mentioned this pull request Dec 7, 2021

[🚧 POC: not for merge] @hashicorp/ember-flight-icons test #12533

Closed

1 task

Merge branch 'main' into ui/flight-icons

d3bab09

vercel bot deployed to Preview – vault December 7, 2021 15:57 View deployment

vercel bot deployed to Preview – vault-storybook December 7, 2021 15:57 View deployment

zofskeez merged commit d811271 into main Dec 7, 2021

zofskeez deleted the ui/flight-icons branch December 7, 2021 17:05

zofskeez added this to the 1.10 milestone Dec 7, 2021

hashishaw mentioned this pull request Jan 3, 2022

Fix status icon color after moving to flight icons #13552

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Incorporate Ember Flight Icons #12976

Incorporate Ember Flight Icons #12976

zofskeez commented Oct 29, 2021 •

edited

Loading

hashishaw left a comment

hashishaw Nov 2, 2021

zofskeez Nov 3, 2021

hashishaw Nov 8, 2021

zofskeez Nov 15, 2021

ivana-mcconnell Nov 23, 2021

zofskeez Dec 6, 2021

hashishaw Nov 2, 2021

zofskeez Nov 3, 2021

zofskeez Dec 6, 2021

hashishaw Nov 2, 2021

zofskeez Nov 3, 2021

hashishaw left a comment

Incorporate Ember Flight Icons #12976

Incorporate Ember Flight Icons #12976

Conversation

zofskeez commented Oct 29, 2021 • edited Loading

hashishaw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hashishaw left a comment

Choose a reason for hiding this comment

zofskeez commented Oct 29, 2021 •

edited

Loading