Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mongo doesnt allow periods in usernames #11872

Merged
merged 6 commits into from
Jun 24, 2021
Merged

Mongo doesnt allow periods in usernames #11872

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f44f2c6
mongo doesnt allow periods in usernames
mr-miles Jun 15, 2021
81c332e
Update mongodb.mdx
mr-miles Jun 18, 2021
4be8e10
Merge branch 'hashicorp:master' into mongo-username
mr-miles Jun 18, 2021
e2d4dd0
Move replace to the end
mr-miles Jun 18, 2021
ef72155
Adding a test for dot replacement
mr-miles Jun 18, 2021
05a02ef
Create 11872.txt
mr-miles Jun 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/database/mongodb/mongodb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (
const (
mongoDBTypeName = "mongodb"

defaultUserNameTemplate = `{{ printf "v-%s-%s-%s-%s" (.DisplayName | truncate 15) (.RoleName | truncate 15) (random 20) (unix_time) | truncate 100 }}`
defaultUserNameTemplate = `{{ printf "v-%s-%s-%s-%s" (.DisplayName | replace "." "-" | truncate 15) (.RoleName | replace "." "-" | truncate 15) (random 20) (unix_time) | truncate 100 }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! What do you think about moving the replace to the end so it only needs to be done once instead of for each of the two fields?

{{ printf "v-%s-%s-%s-%s" (.DisplayName | truncate 15) (.RoleName | truncate 15) (random 20) (unix_time) | replace "." "-" | truncate 100 }}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs and template updated

)

// MongoDB is an implementation of Database interface
Expand Down