Skip to content

Commit

Permalink
Updated website docs and ensured ToLower is used for true comparison
Browse files Browse the repository at this point in the history
  • Loading branch information
Lauren Voswinkel committed May 20, 2020
1 parent 817608c commit bb855a5
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion physical/mysql/mysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ func NewMySQLClient(conf map[string]string, logger log.Logger) (*sql.DB, error)
dsnParams.Add("tls", mysqlTLSKey)
}
ptAllowed, ptOk := conf["plaintext_connection_allowed"]
if !(ptOk && ptAllowed == "true") && !tlsOk {
if !(ptOk && strings.ToLower(ptAllowed) == "true") && !tlsOk {
logger.Warn("No TLS specified, credentials will be sent in plaintext. To mute this warning add 'plaintext_connection_allowed' with a true value to your MySQL configuration in your config file.")
}

Expand Down
6 changes: 4 additions & 2 deletions website/pages/docs/configuration/storage/mysql.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ storage "mysql" {

- `plaintext_credentials_transmission` `(string: "")` - Provides authorization
to send credentials over plaintext. Failure to provide a value AND a failure
to provide a TLS CA certificate will prevent server startup. This is done to
ensure credentials are not leaked accidentally.
to provide a TLS CA certificate will warn that the credentials are being sent
over plain text. In the future, failure to do acknowledge or use TLS will
result in server start being prevented. This will be done to ensure credentials
are not leaked accidentally.

- `max_parallel` `(string: "128")` – Specifies the maximum number of concurrent
requests to MySQL.
Expand Down

0 comments on commit bb855a5

Please sign in to comment.