Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for db schedule-based static role rotations #369

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

fairclothjm
Copy link
Contributor

Add support for the upcoming 1.15 Vault feature

Related docs PR for the feature

We will update integration tests in a separate PR once hashicorp/terraform-provider-vault#2011 is merged. For now we add a unit test to test the changes made in this PR.

@fairclothjm fairclothjm added this to the v0.3.0 milestone Sep 21, 2023
@fairclothjm fairclothjm requested a review from a team as a code owner September 21, 2023 20:45
@benashz benashz self-requested a review September 21, 2023 20:50
@fairclothjm
Copy link
Contributor Author

Working on adding unit test for isStaticCreds

@fairclothjm fairclothjm force-pushed the VAULT-20211/database-static-role-rotation-schedule branch from 522940d to 532f515 Compare September 22, 2023 20:11
Copy link
Collaborator

@benashz benashz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@fairclothjm fairclothjm merged commit 359c71f into main Sep 22, 2023
@fairclothjm fairclothjm deleted the VAULT-20211/database-static-role-rotation-schedule branch September 22, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants