Fix panic from nil logger #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonodonnell
requested review from
calvn,
fairclothjm,
robmonte and
austingebauer
fairclothjm
reviewed
Feb 18, 2022
fairclothjm
approved these changes
Feb 18, 2022
fairclothjm
approved these changes
Feb 18, 2022
calvn
reviewed
Feb 18, 2022
calvn
approved these changes
Feb 18, 2022
jasonodonnell
added a commit
that referenced
this pull request
Feb 18, 2022
* Fix panic from nil logger * Check if logger is nil * Add comment * Update per review
jasonodonnell
added a commit
that referenced
this pull request
Feb 18, 2022
* Fix panic from nil logger * Check if logger is nil * Add comment * Update per review
jasonodonnell
added a commit
that referenced
this pull request
Feb 18, 2022
jasonodonnell
added a commit
that referenced
this pull request
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We aren't passing in a logger, which can cause Vault to panic if it attempts to use a logger in the SDK
ldaputilcode.