Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MongoDB Atlas client library #16

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Update MongoDB Atlas client library #16

merged 1 commit into from
Feb 3, 2021

Conversation

tomhjp
Copy link
Contributor

@tomhjp tomhjp commented Feb 2, 2021 •
edited
Loading

Overview

Update from whitelist to equivalent allow list API endpoints, whitelist will be deprecated June this year.

Acceptance test output:

go test -v ./...
=== RUN   TestAcceptanceProgrammaticAPIKey
=== RUN   TestAcceptanceProgrammaticAPIKey/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey (0.92s)
    --- PASS: TestAcceptanceProgrammaticAPIKey/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey/read_programmatic_API_key_cred (0.53s)
    --- PASS: TestAcceptanceProgrammaticAPIKey/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey/revoke_programmatic_API_key_creds (0.39s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectID/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID (0.87s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID/read_programmatic_API_key_cred (0.28s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectID/revoke_programmatic_API_key_creds (0.59s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/check_lease_for_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/extend_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/check_lease_for_programmatic_API_key_cred#01
=== RUN   TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew (0.80s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/read_programmatic_API_key_cred (0.21s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/check_lease_for_programmatic_API_key_cred (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/extend_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/check_lease_for_programmatic_API_key_cred#01 (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithProjectIDRenew/revoke_programmatic_API_key_creds (0.59s)
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist (1.25s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/read_programmatic_API_key_cred (0.42s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_ProjectWithIPAccesslist/revoke_programmatic_API_key_creds (0.84s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist (0.84s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/read_programmatic_API_key_cred (0.41s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithIPAccesslist/revoke_programmatic_API_key_creds (0.43s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist (0.97s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/read_programmatic_API_key_cred (0.41s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAccesslist/revoke_programmatic_API_key_creds (0.56s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist (0.83s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/read_programmatic_API_key_cred (0.44s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithCIDRAndIPAccesslist/revoke_programmatic_API_key_creds (0.38s)
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject/add_programmatic_API_Key_role
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_AssignToProject/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject (1.32s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject/add_programmatic_API_Key_role (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject/read_programmatic_API_key_cred (0.69s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_AssignToProject/revoke_programmatic_API_key_creds (0.62s)
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/add_config
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/add_programmatic_API_Key_role_with_TTL
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/read_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/check_lease_for_programmatic_API_key_cred
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/renew_programmatic_API_key_creds
=== RUN   TestAcceptanceProgrammaticAPIKey_WithTTL/revoke_programmatic_API_key_creds
--- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL (0.59s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/add_config (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/add_programmatic_API_Key_role_with_TTL (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/read_programmatic_API_key_cred (0.20s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/check_lease_for_programmatic_API_key_cred (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/renew_programmatic_API_key_creds (0.00s)
    --- PASS: TestAcceptanceProgrammaticAPIKey_WithTTL/revoke_programmatic_API_key_creds (0.38s)
=== RUN   TestBackend_PathConfig
--- PASS: TestBackend_PathConfig (0.00s)
=== RUN   TestBackend_PathListCredentials
--- PASS: TestBackend_PathListCredentials (0.00s)
PASS
ok      github.com/hashicorp/vault-plugin-secrets-mongodbatlas  8.721s
?       github.com/hashicorp/vault-plugin-secrets-mongodbatlas/cmd/vault-plugin-secrets-mongodbatlas    [no test files]

Contributor Checklist

  • Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
    • Will add changelog and docs site notes in Vault repo once the database plugin is also updated
  • Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
  • Backwards compatible

@tomhjp tomhjp merged commit 6218edd into master Feb 3, 2021
@tomhjp tomhjp deleted the update-mongodb-atlas-client branch February 3, 2021 18:20
@tomhjp tomhjp mentioned this pull request Feb 3, 2021
Merged
3 tasks
tomhjp added a commit that referenced this pull request Feb 22, 2021
@tomhjp
Move from whitelist to access list API (#16)
afe33f6
@tomhjp tomhjp mentioned this pull request Feb 22, 2021
Merged
tomhjp added a commit that referenced this pull request Feb 22, 2021
@tomhjp
Move from whitelist to access list API (#16) (#18)
009df99
@tomhjp tomhjp mentioned this pull request Feb 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tvoran tvoran tvoran approved these changes

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

@kalafut kalafut Awaiting requested review from kalafut

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomhjp @tvoran