Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /check endpoint to verify env variable setup #18

Merged
merged 7 commits into from
Dec 15, 2022

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Dec 14, 2022

Adds a /check endpoint that will return a 204 if the required environment variables are present, and otherwise returns a 400 with a list of what variables are missing.

I tested manually as well by loading the plugin into a Vault cluster outside of Kubernetes and seeing it returned a 400, and running it in a Kubernetes cluster and seeing it return a 204.

Adds a `/check` endpoint that will return a 204 if the
required environment variables are present, and otherwise
returns a 400 with a list of what variables are missing.
@swenson swenson requested a review from tvoran December 14, 2022 18:32
Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple thoughts, but 👍

path_check.go Outdated Show resolved Hide resolved
path_check.go Outdated Show resolved Hide resolved
integrationtest/integration_test.go Outdated Show resolved Hide resolved
path_check.go Show resolved Hide resolved
Christopher Swenson and others added 5 commits December 15, 2022 09:05
@swenson
Copy link
Contributor Author

swenson commented Dec 15, 2022

Thanks!

@swenson swenson merged commit 6b1994e into main Dec 15, 2022
@swenson swenson deleted the vault-9846/config-viability branch December 15, 2022 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants