Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependencies #109

Merged
merged 5 commits into from
Nov 7, 2022
Merged

update dependencies #109

merged 5 commits into from
Nov 7, 2022

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Oct 31, 2022

Updates go version from 1.12 to 1.19 and also upgrades dependencies with the following command:

go list -u -m -json all | jq -r 'select(.Indirect != true and .Update != null) | .Path+"@"+.Update.Version' | xargs -L1 go get
go mod tidy

Dependencies updated:

 go: downloading github.com/Azure/azure-sdk-for-go v67.0.0+incompatible
 go: upgraded github.com/Azure/azure-sdk-for-go v58.3.0+incompatible => v67.0.0+incompatible
 go: downloading github.com/Azure/go-autorest/autorest v0.11.28
 go: downloading golang.org/x/crypto v0.0.0-20220722155217-630584e8d5aa
 go: downloading github.com/Azure/go-autorest/autorest/mocks v0.4.2
 go: downloading golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1
 go: upgraded github.com/Azure/go-autorest/autorest v0.11.21 => v0.11.28
 go: upgraded github.com/Azure/go-autorest/autorest/adal v0.9.14 => v0.9.18
 go: added github.com/golang-jwt/jwt/v4 v4.2.0
 go: upgraded golang.org/x/crypto v0.0.0-20210513164829-c07d793c2f9a => v0.0.0-20220722155217-630584e8d5aa
 go: upgraded github.com/Azure/go-autorest/autorest/azure/auth v0.5.8 => v0.5.11
 go: upgraded github.com/Azure/go-autorest/autorest/azure/cli v0.4.2 => v0.4.5
 go: downloading github.com/stretchr/testify v1.7.2
 go: upgraded github.com/fatih/color v1.9.0 => v1.13.0
 go: upgraded github.com/hashicorp/go-hclog v1.0.0 => v1.3.1
 go: upgraded github.com/mattn/go-colorable v0.1.6 => v0.1.12
 go: upgraded github.com/mattn/go-isatty v0.0.12 => v0.0.14
 go: upgraded golang.org/x/sys v0.0.0-20210615035016-665e8c7367d1 => v0.0.0-20220503163025-988cb79eb6c6
 go: upgraded github.com/hashicorp/go-uuid v1.0.2 => v1.0.3
 go: downloading github.com/hashicorp/vault/api v1.8.2
 go: downloading golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f
 go: downloading gopkg.in/check.v1 v1.0.0-20180628173108-788fd7840127
 go: upgraded github.com/armon/go-metrics v0.3.3 => v0.3.9
 go: upgraded github.com/golang/protobuf v1.4.2 => v1.5.2
 go: upgraded github.com/golang/snappy v0.0.1 => v0.0.4
 go: upgraded github.com/hashicorp/go-cleanhttp v0.5.1 => v0.5.2
 go: upgraded github.com/hashicorp/go-immutable-radix v1.1.0 => v1.3.1
 go: upgraded github.com/hashicorp/go-plugin v1.0.1 => v1.4.5
 go: added github.com/hashicorp/go-secure-stdlib/mlock v0.1.1
 go: upgraded github.com/hashicorp/go-secure-stdlib/parseutil v0.1.1 => v0.1.6
 go: upgraded github.com/hashicorp/go-secure-stdlib/strutil v0.1.1 => v0.1.2
 go: upgraded github.com/hashicorp/golang-lru v0.5.3 => v0.5.4
 go: upgraded github.com/hashicorp/vault/api v1.2.0 => v1.8.2
 go: upgraded github.com/hashicorp/vault/sdk v0.2.1 => v0.6.0
 go: upgraded github.com/mitchellh/mapstructure v1.4.2 => v1.5.0
 go: upgraded go.uber.org/atomic v1.6.0 => v1.9.0
 go: upgraded golang.org/x/sys v0.0.0-20220503163025-988cb79eb6c6 => v0.0.0-20220722155257-8c9f86f7a55f
 go: upgraded golang.org/x/text v0.3.6 => v0.3.8
 go: upgraded google.golang.org/grpc v1.29.1 => v1.41.0
 go: upgraded google.golang.org/protobuf v1.25.0 => v1.26.0
 go: downloading github.com/hashicorp/vault/sdk v0.6.1
 go: downloading github.com/hashicorp/vault v0.6.1
 go: upgraded github.com/hashicorp/vault/sdk v0.6.0 => v0.6.1

Output from testing:

$ make test

=== RUN   TestPeriodicFuncNilConfig
2022-10-31T14:45:38.746-0700 [DEBUG] starting periodic func
--- PASS: TestPeriodicFuncNilConfig (1.00s)
...
...
PASS (12.00s)
ok      github.com/hashicorp/vault-plugin-secrets-azure

$  make test-acceptance AZURE_TENANT_ID=<TENANT_ID>

✓ Azure Secrets Engine - MS Graph

1 test, 0 failures

@vinay-gopalan vinay-gopalan marked this pull request as ready for review October 31, 2022 22:06
@vinay-gopalan vinay-gopalan requested a review from a team November 2, 2022 20:58
Copy link
Contributor Author

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be an issue with connecting to the Azure service to setup acceptance test resources via TF; investigating, in the meantime manual tests and all unit tests pass

Copy link
Member

@robmonte robmonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vinay-gopalan
Copy link
Contributor Author

Acceptance tests were fixed and they pass

@vinay-gopalan vinay-gopalan merged commit 7f4e895 into main Nov 7, 2022
@vinay-gopalan vinay-gopalan deleted the VAULT-9504/update-dependencies branch November 7, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants