Add support for JWT signature algorithm ES384 (support removed since 1.13.0) #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The JWT signature algorithm wasn't supported, while RS384 was twice. Without this algorithm some Kubernetes clusters can't authenticate.
jeroenvdheuvel
force-pushed
the
support-alg-es384
branch
from
98f75aa to
89fcd32
Compare
jeroenvdheuvel
changed the title
tomhjp
approved these changes
Sep 1, 2022
tomhjp
pushed a commit
that referenced
this pull request
Sep 5, 2022
The JWT signature algorithm wasn't supported, while RS384 was twice. Without this algorithm some Kubernetes clusters can't authenticate.
tomhjp
added a commit
that referenced
this pull request
Sep 6, 2022
The JWT signature algorithm wasn't supported, while RS384 was twice. Without this algorithm some Kubernetes clusters can't authenticate. Co-authored-by: Jeroen van den Heuvel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add support for the previously supported JWT signing algorithm ES384. Support for this algorithm is likely removed accidentally in the change switch from golang-jwt to cap+jose.
Kubernetes supports this algorithm, without it some Kubernetes clusters can't authenticate to Vault.
Related Issues/Pull Requests
Issue #159